Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing WITH_BENCHMARK flag (microbenchmarking with google/benchmark) #1244

Merged
merged 5 commits into from
Mar 5, 2017
Merged

Fixing WITH_BENCHMARK flag (microbenchmarking with google/benchmark) #1244

merged 5 commits into from
Mar 5, 2017

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented Feb 16, 2017 •
edited
Loading

PR Description

Fixing the WITH_BENCHMARK flag of DGtal (micro-benchmarking using google/benchmark)

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@dcoeurjo dcoeurjo mentioned this pull request Feb 16, 2017
Closed
@dcoeurjo dcoeurjo changed the title Fixing benchmark Fixing WITH_BENCHMARK flag (microbenchmarking with google/benchmark) Feb 16, 2017
@kerautret kerautret self-requested a review March 2, 2017 21:03
kerautret
kerautret approved these changes Mar 2, 2017
View reviewed changes
Copy link
Member

@kerautret kerautret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and all looks fine ;)
Just perhaps merge from master but I try to solve it online it looks new ;)

@kerautret
Copy link
Member

all looks fine with also new codacy so merging ;)

@kerautret kerautret merged commit 9b037dc into DGtal-team:master Mar 5, 2017
@dcoeurjo dcoeurjo deleted the FixingBenchmark branch October 7, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerautret kerautret kerautret approved these changes

Assignees
No one assigned
Labels
Build ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcoeurjo @kerautret