fix compilation from swift wrapping #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoeurjo
reviewed
Feb 27, 2018
src/DGtal/base/Trace.ih
Outdated
| @@ -259,7 +259,7 @@ DGtal::Trace::progressBar(const double currentValue, const double maximumValue) | |||
| } | |||
| // and back to line begin - do not forget the fflush to avoid output buffering problems! | |||
|
|
|||
| BOOST_STATIC_CONSTANT(std::string, rotation_string = "|\\-/"); | |||
| std::string rotation_string = "|\\-/"; | |||
There was a problem hiding this comment.
const std::string ... ?
(I agree that the static stuff is not necessary)
|
could you please merge the master ? |
|
(+ changelog?) |
|
done ;) |
|
thanks merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Small fix which appears by using DGtal in swift based application.
Checklist
cmakemode (otherwise, Travis C.I. will fail).