Implement operator= in ImageContainerByITKImage #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phcerdan
force-pushed
the
add_operator_equal_ITKImageContainer
branch
from
035744a
to
9153b55
Compare
phcerdan
added a commit
to phcerdan/SGEXT
that referenced
this pull request
Jul 18, 2018
Provide an optional argument taking the distance map generated in the script create_distance_map. It would be required when --select=dmax It requires a DGtal version with: DGtal-team/DGtal#1336 merged.
|
Let me know if I can improve anything here. I think not having implemented it was just because nobody used it before. The base class defines the assignment operator, and all the other subclasses of ImageContainers have the operator implemented. |
rolanddenis
reviewed
Jul 20, 2018
| if (this != &other) | ||
| { | ||
| myITKImagePointer = other.myITKImagePointer; | ||
| myDomain = other.myDomain; |
There was a problem hiding this comment.
Should updateDomain be called here instead of copying domain, like in the copy constructor ?
phcerdan
force-pushed
the
add_operator_equal_ITKImageContainer
branch
from
9153b55
to
2b71dc2
Compare
|
Thanks @rolanddenis for the review, fixed, using |
|
Seems good, merging 😉 Thanks ! |
phcerdan
added a commit
to phcerdan/SGEXT
that referenced
this pull request
Jan 26, 2021
Provide an optional argument taking the distance map generated in the script create_distance_map. It would be required when --select=dmax It requires a DGtal version with: DGtal-team/DGtal#1336 merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmakemode (otherwise, Travis C.I. will fail).