Warnings corrections #1384
Merged
Warnings corrections #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove typedef from .ih file already present in .h file. In Debug mode, gcc 8.2.1, warns that this declaration shadows a previous typedef [-Wshadow]
In Debug, gcc 8.2.1 warns about exceptions not caught by reference [-Wcatch-value, enabled by -Wall].
In Debug, gcc 8.2.1, warns on useless const qualifiers on cast result types [-Wignored-qualifiers, enabled by -Wextra].
In Debug mode, -Wshadow of gcc 8.2.1 warns that Scalar typedef shadows previous typedef in src/DGtal/geometry/surfaces/estimation/IntegralInvariantCovarianceEstimator.h:161
In Debug mode, -Wshadow of gcc 8.2.1 warns that Scalar typedef shadows previous typedef in src/DGtal/geometry/surfaces/estimation/IntegralInvariantVolumeEstimator.h:159
In Debug mode, -Wshadow of gcc 8.2.1 warns that NormalFunctor typedef shadows previous typedef in src/DGtal/helpers/ShortcutsGeometry.h:156
In Debug mode, -Wshadow of gcc 8.2.1 warns that RealPoint typedef shadows previous typedef in src/DGtal/shapes/parametric/StarShaped3D.h:76
In Debug mode, -Wshadow of gcc 8.2.1 warns that Point typedef shadows previous typedef at tests/topology/testVoxelComplex.cpp:452
|
Hi @BorisMansencal |
clang 7.0 was complaining that the comment was not a valid Doxygen comment.
|
@dcoeurjo it seems ok. |
|
thanks @BorisMansencal , I'm on it |
dcoeurjo
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR correct some warnings when compiled in Debug mode, with gcc 8.2.1:
Combined with all corrections of PR #1379 no more warnings are produced when compiling in Debug mode (with gcc 8.2.1 or clang 7) with ITK enabled.
For the "correct shadowed typedefs" commits, you should thoroughly check that my changes are correct. I have documented in the commit messages which typedef is shadowed.
Checklist
cmakemode (otherwise, Travis C.I. will fail).