Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a moveTo() function in implicit and star shapes #1414

Merged
merged 9 commits into from
Aug 24, 2019

Conversation

akrah
Copy link
Contributor

@akrah akrah commented May 31, 2019

PR Description

Add the ability to move the shape center in DGtal/shapes/parametric and DGtal/shapes/implicit packages.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@dcoeurjo
Copy link
Member

Looks ok.. could you please add a short unit test and a changelog entry ?

Up to you but you could also update the shape module page..

@akrah
Copy link
Contributor Author

akrah commented Jun 17, 2019

About the unit test, do you prefer:

  • a test file per shape that test all methods of one shape?
  • a test file per method that test one method for all shapes?

@dcoeurjo
Copy link
Member

I would say a single test file for all shapes /methods.. with different test cases.

@akrah
Copy link
Contributor Author

akrah commented Jul 8, 2019

Travis failed with his message:

E: There were unauthenticated packages and -y was used without --allow-unauthenticated

and these apt warnings:

W: GPG error: http://ppa.launchpad.net/ubuntu-toolchain-r/test/ubuntu trusty InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 1E9377A2BA9EF27F
W: The repository 'http://ppa.launchpad.net/ubuntu-toolchain-r/test/ubuntu trusty InRelease' is not signed.
W: There is no public key available for the following key IDs: 1E9377A2BA9EF27F
W: http://ppa.launchpad.net/couchdb/stable/ubuntu/dists/trusty/Release.gpg: Signature by key 15866BAFD9BCC4F3C1E0DFC7D69548E1C17EAB57 uses weak digest algorithm (SHA1)
W: GPG error: https://packagecloud.io/github/git-lfs/ubuntu trusty InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 6B05F25D762E3157
W: The repository 'https://packagecloud.io/github/git-lfs/ubuntu trusty InRelease' is not signed.
W: There is no public key available for the following key IDs: 6B05F25D762E3157

Is it a Travis configuration error? I think I cannot address this problem in this PR.

@akrah akrah mentioned this pull request Jul 10, 2019
6 tasks
@akrah akrah changed the title Add a moveTo(const RealPoint& point) function in implicit and star sh… Add a moveTo() function in implicit and star shapes Jul 19, 2019
@akrah
Copy link
Contributor Author

akrah commented Jul 19, 2019

@dcoeurjo All looks good for me now.

@dcoeurjo
Copy link
Member

allright. thx

Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good thnaks

@dcoeurjo dcoeurjo merged commit adc2844 into DGtal-team:master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants