Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to Catch2 #1418

Merged
merged 10 commits into from
Jun 15, 2019
Merged

Upgrading to Catch2 #1418

merged 10 commits into from
Jun 15, 2019

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented Jun 13, 2019

PR Description

Upgrading the unit-test framework to Catch2 (https:/catchorg/Catch2)

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@dcoeurjo dcoeurjo added the Build label Jun 13, 2019
@dcoeurjo dcoeurjo changed the title [wip] Upgrading to Catch2 Upgrading to Catch2 Jun 14, 2019
@rolanddenis
Copy link
Member

Since I still had some comparison failures in testRealFFT, I have replaced the margin by a scale defined from the compared values. I hope it will work!

BTW, in the previous version of Catch, the scale was defined to 1 by default (see https:/DGtal-team/DGtal/blob/master/tests/catch.hpp#L2644).

tests/kernel/testPointVector.cpp Outdated Show resolved Hide resolved
@rolanddenis
Copy link
Member

Merging, thanks!

@rolanddenis rolanddenis merged commit a53207a into DGtal-team:master Jun 15, 2019
@dcoeurjo
Copy link
Member Author

🎉 ;)

@dcoeurjo dcoeurjo deleted the catch2 branch October 7, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants