Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable testVoronoiCovarianceMeasureOnSurface test #1439

Merged
merged 3 commits into from
Oct 30, 2019
Merged

Re-enable testVoronoiCovarianceMeasureOnSurface test #1439

merged 3 commits into from
Oct 30, 2019

Conversation

dcoeurjo
Copy link
Member

PR Description

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@dcoeurjo
Copy link
Member Author

@JacquesOlivierLachaud could you please have a look ? the test is failing at line 196

JacquesOlivierLachaud
JacquesOlivierLachaud approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@JacquesOlivierLachaud JacquesOlivierLachaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was related to bad parameter settings.
However, I am not at all certain that VCM induces a convergent curvature estimator.

@JacquesOlivierLachaud JacquesOlivierLachaud merged commit fd7f5b6 into DGtal-team:master Oct 30, 2019
@dcoeurjo dcoeurjo deleted the testVCM branch October 7, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesOlivierLachaud JacquesOlivierLachaud JacquesOlivierLachaud approved these changes

Assignees
No one assigned
Labels
Geometry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcoeurjo @JacquesOlivierLachaud