Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fixing Travis build #1465

Merged
merged 3 commits into from
Mar 15, 2020
Merged

Conversation

rolanddenis
Copy link
Member

@rolanddenis rolanddenis commented Mar 15, 2020

PR Description

Fixing Travis conflict between matrix and jobs directives, and some other warnings and infos (see #1463)

We should maybe wait a little bit before merging in case of deployment of Travis dpl v2 was a mistake...

Checklist

  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@dcoeurjo
Copy link
Member

waoh.. thx for the debug.... looks like you've spotted the bug.
How did you find it?

@dcoeurjo
Copy link
Member

👌 merging this one BTW (fixes Bertrand's mail)

@dcoeurjo dcoeurjo merged commit 65576fb into DGtal-team:master Mar 15, 2020
@dcoeurjo
Copy link
Member

oops I merged the wrong duplicate :)

@dcoeurjo
Copy link
Member

could you just push a Changelog entry ?

@rolanddenis
Copy link
Member Author

waoh.. thx for the debug.... looks like you've spotted the bug.
How did you find it?

No magic 😅 : in the job details from your PR : https://travis-ci.org/github/DGtal-team/DGtal/builds/662684925/config?utm_medium=notification&utm_source=github_status

Just below the two tabs Buid jobs and View config, there is a line Build config validation with a red cross meaning that there is an error in the config. Expanding the line, it tolds about a conflict between matrix and jobs. In the (not completely updated...) documentation of Travis, I understand that matrix and jobs directives have been merged in the dpl v2 (that is still documented as in beta stage...)

@rolanddenis rolanddenis deleted the fix_travis branch March 16, 2020 10:17
rolanddenis added a commit to rolanddenis/DGtal that referenced this pull request Mar 16, 2020
rolanddenis added a commit that referenced this pull request Mar 16, 2020
@dcoeurjo
Copy link
Member

👌 thx

dcoeurjo added a commit that referenced this pull request Oct 2, 2020
dcoeurjo pushed a commit that referenced this pull request Oct 2, 2020
dcoeurjo pushed a commit that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants