Fix const iterator issue1437 #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerautret
changed the title
kerautret
changed the title
dcoeurjo
requested changes
Apr 10, 2020
ChangeLog.md
Outdated
| @@ -135,7 +135,10 @@ | |||
| (David Coeurjolly, [#1446](https:/DGtal-team/DGtal/pull/1446)) | |||
| - Removes the check for CPP11 when building WITH_ITK | |||
| (Pablo Hernandez-Cerdan, [#1453](https:/DGtal-team/DGtal/pull/1453)) | |||
|
|
|||
| - Fix apple clang compilation issue with a workaround to the | |||
| ConstIteratorAdapter that do not satisfy the _is_forward concept of the STL: | |||
There was a problem hiding this comment.
Suggested change
| ConstIteratorAdapter that do not satisfy the _is_forward concept of the STL: | |
| ConstIteratorAdapter class that does not satisfy the _is_forward concept of the STL: |
There was a problem hiding this comment.
thanks, I miss the commit suggestion since my emacs was open on it but that looks nice!
|
thx for the PR |
|
All good ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
See issue #1437
Checklist
cmakemode (otherwise, Travis C.I. will fail).