Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Board3DTo2D cleanup and fixes #1537

Merged
merged 13 commits into from
Dec 27, 2020
Merged

Board3DTo2D cleanup and fixes #1537

merged 13 commits into from
Dec 27, 2020

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented Dec 20, 2020 •
edited
Loading

PR Description

Various fixes in the Board3DTo2D class.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

dcoeurjo
dcoeurjo commented Dec 27, 2020
View reviewed changes
ChangeLog.md Outdated Show resolved Hide resolved
@dcoeurjo
Copy link
Member Author

Merging this one. Minor stuff and it fixes the travis macOS bot..

@dcoeurjo dcoeurjo merged commit 217b75f into DGtal-team:master Dec 27, 2020
@dcoeurjo dcoeurjo deleted the 3dTo2dFix branch December 27, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dcoeurjo