Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Obj format in MeshReader including colors #1584

Merged
merged 26 commits into from
Sep 9, 2021

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented Jul 15, 2021

PR Description

Add Obj format in MeshReader including colors.
All DgtalTools viewer will be able to read and display obj mesh without any changes.
It is based on the same code of SurfaceMeshReader with adaptation by removing normal read and adding mtl file reading to recover colors.

  • It fix an error on obj file with relative face reference (also applied in SurfaceMeshReader)

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@kerautret
Copy link
Member Author

Codacy issue looks a bug or I miss something...
The two spaces are well here:
Capture d’écran 2021-07-15 à 22 32 05

@dcoeurjo
Copy link
Member

travis is back...

Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR. Just some comments

src/DGtal/io/readers/MeshReader.h Show resolved Hide resolved
src/DGtal/io/readers/MeshReader.h Outdated Show resolved Hide resolved
src/DGtal/io/readers/MeshReader.ih Outdated Show resolved Hide resolved
src/DGtal/io/readers/MeshReader.ih Outdated Show resolved Hide resolved
@dcoeurjo
Copy link
Member

Please use the clang format to have the proper code formatting (there is a .clang-format in the project)

1 similar comment
@dcoeurjo
Copy link
Member

Please use the clang format to have the proper code formatting (there is a .clang-format in the project)

@dcoeurjo
Copy link
Member

Ok the Exclude is not working...

@dcoeurjo dcoeurjo merged commit e44c45b into DGtal-team:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants