-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Obj format in MeshReader including colors #1584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis is back... |
dcoeurjo
reviewed
Jul 22, 2021
dcoeurjo
reviewed
Aug 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the PR. Just some comments
Please use the clang format to have the proper code formatting (there is a .clang-format in the project) |
1 similar comment
Please use the clang format to have the proper code formatting (there is a .clang-format in the project) |
thanks Co-authored-by: David Coeurjolly <[email protected]>
Ok the Exclude is not working... |
dcoeurjo
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add Obj format in MeshReader including colors.
All DgtalTools viewer will be able to read and display obj mesh without any changes.
It is based on the same code of SurfaceMeshReader with adaptation by removing normal read and adding mtl file reading to recover colors.
Checklist
cmake
mode (otherwise, Travis C.I. will fail).