Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full convexity #1594

Merged
merged 89 commits into from
Nov 16, 2021
Merged

Full convexity #1594

merged 89 commits into from
Nov 16, 2021

Conversation

JacquesOlivierLachaud
Copy link
Member

@JacquesOlivierLachaud JacquesOlivierLachaud commented Aug 23, 2021 •
edited
Loading

PR Description

This PR completes the module on Digital Convexity with new functions related to full convexity. In particular, it provides an algorithm to check full convexity for arbitrary digital sets in nD, and proposes several helper classes for using full convexity in practice: one dedicated to local geometric analysis, the other devoted to tangency and shortest paths.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@JacquesOlivierLachaud
Add code for degenerated polytopes in ConvexityHelper
666a00a
@JacquesOlivierLachaud
First working version for degenerated polytopes in ConvexityHelper
b1f598b
@JacquesOlivierLachaud
Remove debug information
6d1d3c2
@JacquesOlivierLachaud
Add generic algorithm for checking full convexity to class DigitalCon…
060b1db 
…vexity
@JacquesOlivierLachaud
Fix forgotten dimension test in CellGeometry::addCellsTouchingPointel…
2300190 
…s and CellGeometry::addCellsTouchingPoints
@JacquesOlivierLachaud
Working version of full convexity
d1c76a7
@JacquesOlivierLachaud
Clean stuff
bffef14
@JacquesOlivierLachaud
Add simple neighborhood convexity analyzer
e122e30
@JacquesOlivierLachaud
Working on full convexity local tests
4f3fbab
@JacquesOlivierLachaud
Working on shape analysis with convexity
1751cc3
@JacquesOlivierLachaud
Working on geometric analysis and geometric thinning
2e22b8f
@JacquesOlivierLachaud
Update UnorderedSetByBlock
2bedfaa
@JacquesOlivierLachaud
First working version of segment intersection
0e3bf6c
@JacquesOlivierLachaud
New CellGeometry::addCellsTouchingSegment and DigitalConvexity::isFul…
707439c 
…lySubconvex on segment are 3 times faster
@JacquesOlivierLachaud
Fix CellGeometry::addCellsTouchingSegment
55209d0
@JacquesOlivierLachaud
Small clean-up
7cdc445
@JacquesOlivierLachaud
Update doc and test
233f26d
@JacquesOlivierLachaud
Add 3D segment test for CellGeometry
ffc2c30
@JacquesOlivierLachaud
Cleaning up TimeStampMemoizer
655bdbe
@JacquesOlivierLachaud
Update geometricAnalysis3D example
4ed57f8
@JacquesOlivierLachaud
Update geometricAnalysis3D example and doc
efd954f
@JacquesOlivierLachaud
Starting doc for apps of full convexity
275dbc5
@JacquesOlivierLachaud
Add images and working on doc
bb8093f
@JacquesOlivierLachaud
Fix bug in NeighborhoodConvexityAnalyzer and update example geometric…
13c9099 
…Analysis3D
@JacquesOlivierLachaud
Fixing TangencyComputer
1cfaf70
@JacquesOlivierLachaud
Add tangency services
cb083a7
@JacquesOlivierLachaud
Add shortest paths example
4fc0bca
@JacquesOlivierLachaud
Add LUT computation example
e31b15e
@JacquesOlivierLachaud
Simplifying shortestPaths3D
3fcce2b
@JacquesOlivierLachaud
Add images to doc
9e65669
@dcoeurjo dcoeurjo self-requested a review October 14, 2021 08:54
dcoeurjo
dcoeurjo requested changes Oct 14, 2021
View reviewed changes
Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last batch, thx

src/DGtal/geometry/volumes/CellGeometry.ih Outdated Show resolved Hide resolved
src/DGtal/geometry/volumes/ConvexityHelper.h Outdated Show resolved Hide resolved
src/DGtal/geometry/volumes/DigitalConvexity.ih Outdated Show resolved Hide resolved
src/DGtal/geometry/volumes/NeighborhoodConvexityAnalyzer.h Outdated Show resolved Hide resolved
src/DGtal/geometry/volumes/NeighborhoodConvexityAnalyzer.h Outdated Show resolved Hide resolved
src/DGtal/kernel/UnorderedSetByBlock.h Outdated Show resolved Hide resolved
ChangeLog.md Outdated Show resolved Hide resolved
src/DGtal/math/LagrangeInterpolation.h Outdated Show resolved Hide resolved
@dcoeurjo dcoeurjo self-requested a review November 8, 2021 09:46
dcoeurjo
dcoeurjo reviewed Nov 8, 2021
View reviewed changes
Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor questions. Otherwise, no more comments, thx

@JacquesOlivierLachaud
Copy link
Member Author

Should be fine now.

@dcoeurjo
Copy link
Member

Great, thx

@dcoeurjo dcoeurjo self-requested a review November 16, 2021 12:41
@dcoeurjo dcoeurjo self-assigned this Nov 16, 2021
dcoeurjo
dcoeurjo approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@dcoeurjo dcoeurjo merged commit 1346979 into DGtal-team:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoeurjo dcoeurjo dcoeurjo approved these changes

Assignees

@dcoeurjo dcoeurjo

Labels
Geometry ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JacquesOlivierLachaud @dcoeurjo