Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PULL_REQUEST_TEMPLATE.md #1595

Merged
merged 3 commits into from
Aug 24, 2021
Merged

Update PULL_REQUEST_TEMPLATE.md #1595

merged 3 commits into from
Aug 24, 2021

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented Aug 24, 2021 •
edited
Loading

PR Description

your description here

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@dcoeurjo dcoeurjo merged commit f89a16b into master Aug 24, 2021
@dcoeurjo dcoeurjo deleted the dcoeurjo-patch-2 branch August 24, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerautret kerautret kerautret approved these changes

Assignees
No one assigned
Labels
ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcoeurjo @kerautret