-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete Voronoi Map #1605
Complete Voronoi Map #1605
Conversation
This one can be reviewed too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, just found some small typos and edits
Co-authored-by: Bertrand Kerautret <[email protected]>
All good, thx @kerautret for the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine 👍🏻 Thanks, Just perhaps have a look on the indent of the parameter constructor (see annote)
Thx again for the review. |
You are welcome, yes fine that could be also done after with other classes ;) |
Co-authored-by: Bertrand Kerautret <[email protected]>
Co-authored-by: Bertrand Kerautret <[email protected]>
Co-authored-by: Bertrand Kerautret <[email protected]>
Co-authored-by: Bertrand Kerautret <[email protected]>
PR Description
New VoronoiMap class to compute the complete V\cap\mathbb{Z}^d map (aka with all co-cyclic points).
Cherrypicking from Robin Lamy (ENSIMAG), Isabelle Sivignon (GIPSA-Lab).
TODO:
Checklist
cmake
mode (otherwise, C.I. will fail).