Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to CMake: DGTAL_WRAP_PYTHON #1700

Merged
merged 3 commits into from
Sep 9, 2023
Merged

Add option to CMake: DGTAL_WRAP_PYTHON #1700

merged 3 commits into from
Sep 9, 2023

Conversation

phcerdan
Copy link
Member

@phcerdan phcerdan commented Jun 28, 2023 •
edited
Loading

PR Description

Add option to CMake: DGTAL_WRAP_PYTHON for it to appear in ccmake and
other GUI interfaces to CMake.

OFF by default.

Also fix a few warnings in release mode

Checklist

  • [NA] Unit-test of your feature with Catch.
  • [NA] Doxygen documentation of the code completed (classes, methods, types, members...)
  • [NA] Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions & appveyor)

@phcerdan
CMake: Add DGTAL_WRAP_PYTHON option
d2fb9c7 
For the option to appear in ccmake and other grafical interfaces

OFF by default
@phcerdan
Fix a few warnings in Release mode
b833e71
@phcerdan phcerdan force-pushed the add_wrap_python_cmake_option branch from 6edc32e to b833e71 Compare June 28, 2023 09:55
@phcerdan phcerdan changed the title # PR Description Add option to CMake: DGTAL_WRAP_PYTHON Jun 28, 2023
@phcerdan phcerdan requested a review from dcoeurjo June 28, 2023 09:57
dcoeurjo
dcoeurjo approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in the review, I missed this PR. Thanks for the contribution.Everything looks fine, let's wait for the CI bots.
(I'll check the python build on my system)

@dcoeurjo
Copy link
Member

dcoeurjo commented Sep 9, 2023

👌merging. Thanks

@dcoeurjo dcoeurjo merged commit ad47648 into DGtal-team:master Sep 9, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoeurjo dcoeurjo dcoeurjo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phcerdan @dcoeurjo