Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing warnings for libIGL related code on GCC and Clang #1722

Merged
merged 2 commits into from
May 8, 2024
Merged

Removing warnings for libIGL related code on GCC and Clang #1722

merged 2 commits into from
May 8, 2024

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented May 8, 2024 •
edited
Loading

PR Description

Warnings inside libIGL can make the CI bots fail due to -Werror debug flags.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions)

@dcoeurjo
Copy link
Member Author

dcoeurjo commented May 8, 2024

Merging this one to update the other PR failing because of libIGL warnings

@dcoeurjo dcoeurjo merged commit 820b28c into master May 8, 2024
13 of 21 checks passed
@dcoeurjo dcoeurjo deleted the IgnoreIGLWarnings branch May 8, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dcoeurjo