Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix board spherical #980

Merged
merged 8 commits into from
Apr 8, 2015
Merged

Conversation

dcoeurjo
Copy link
Member

Bugfix in quad visualization in BoardD3D and Viewer3D

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 90.35% when pulling 0e53264 on dcoeurjo:FixBoardSpherical into ac65f35 on DGtal-team:master.

@kerautret
Copy link
Member

@dcoeurjo From just a test it looks that exported normals are not always near surface exterior.
I tested it from the 3DCurvatureViewer PR of Jeremy with Al.vol...

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Apr 1, 2015

Sorry but I don't understand what you mean

@kerautret
Copy link
Member

I don't know if it is related to your edit but in the export of voxel primitive the face order should be in inverted in some direction see:
capture d ecran 2015-04-01 a 08 20 37

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Apr 1, 2015

which tool generates this vector field ?

@kerautret
Copy link
Member

meshlab...

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Apr 7, 2015

well.. I don't know.. elementary normal vectors to quad is something highly dependent on how you create the quads.. Can you please provide an example with a single cube ?

@kerautret
Copy link
Member

Yes here is what we obtain from obj of a single voxel centered in 0: (the sequence is perhaps not good)

OBJ format

generated from Board3D from the DGTal library

mtllib test.mtl

o 0
usemtl Mat_0
v -0.5 -0.5 0.5
v 0.5 -0.5 0.5
v -0.5 -0.5 -0.5
v 0.5 -0.5 -0.5
v -0.5 0.5 0.5
v 0.5 0.5 0.5
v -0.5 0.5 -0.5
v 0.5 0.5 -0.5
vn -1 0 0
vn 0 0 -1
vn 0 1 0
vn 0 0 1
vn 0 -1 0
vn 1 0 0
f -8//-6 -7//-6 -5//-6 -6//-6
f -8//-5 -6//-5 -2//-5 -4//-5
f -8//-4 -7//-4 -3//-4 -4//-4
f -7//-3 -5//-3 -1//-3 -3//-3
f -6//-2 -5//-2 -1//-2 -2//-2
f -4//-1 -3//-1 -1//-1 -2//-1

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Apr 8, 2015

Did you send a cube or a digital surface surfel set to the board3d ?

@kerautret
Copy link
Member

a digital point with mode paving:
aBoard << SetMode3D("PointVector", "Paving");
aBoard << Point(0,0,0);
aBoard.saveOBJ("test.obj");

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Apr 8, 2015

Ok so it has nothing to do with my PR (I only change things in Quad drawing)

@kerautret
Copy link
Member

Yes, the pb looks to be present in the master, we perhaps have miss it in previous PR...

@kerautret
Copy link
Member

I add an issue on that.

@kerautret
Copy link
Member

could you update from master for merging ?

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Apr 8, 2015

Done

@kerautret
Copy link
Member

thanks , I add an issue, sorry for the false bug, waiting for travis and merging

@kerautret
Copy link
Member

travis looks too long for some config, merging

kerautret added a commit that referenced this pull request Apr 8, 2015
@kerautret kerautret merged commit 642eb44 into DGtal-team:master Apr 8, 2015
@dcoeurjo dcoeurjo deleted the FixBoardSpherical branch May 20, 2015 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants