Fix bug of 3dCurvatureViewer and 3dCurvatureViewerNoise #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works with @akrah computer, perhaps just wait the Markus test ;) |
|
Does the fix hide another bug in KSpace::lowerBound and upperBound ? |
|
Yes perhaps since I changed the KSpace::lowerBound into KSpace::lowerCell but it could be also the KSpace::uNext( p, dir_low_uid, dir_up_uid ) which continue when cell of lower dim are given ? |
|
Thanks, merging |
dcoeurjo
added a commit
that referenced
this pull request
Apr 27, 2015
Fix bug of 3dCurvatureViewer and 3dCurvatureViewerNoise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bounds were never good in the scanner (lower dim).
Perhaps @JacquesOlivierLachaud can confirm since I back port it from ImaGene ;)