Fix wrong behaviours in Promise.race() and Promise.All() functions

The assertions were wrong, if the given `iterable` was not an `Object` or not an `ArrayObject` the promise should have been just rejected.
Fixes Samsung#25
Fixes Samsung#30

Signed-off-by: Daniel Balla [email protected]

src/runtime/GlobalObjectBuiltinPromise.cpp

@@ -93,7 +93,10 @@ static Value builtinPromiseAll(ExecutionState& state, Value thisValue, size_t ar
  remainingElementsCount->defineOwnProperty(state, strings->value, ObjectPropertyDescriptor(Value(1), ObjectPropertyDescriptor::AllPresent));
  uint32_t index = 0;
 
- ASSERT(iterable->isArrayObject()); // TODO
+ if (!iterable->isArrayObject()) {
+ return capability.m_rejectFunction;
+ }
+
  ArrayObject* iterableArray = iterable->asArrayObject();
 
  // 6. Repeat
@@ -205,7 +208,10 @@ static Value builtinPromiseRace(ExecutionState& state, Value thisValue, size_t a
  ArrayObject* values = new ArrayObject(state);
  uint32_t index = 0;
 
- ASSERT(iterable->isArrayObject()); // TODO
+ if (!iterable->isArrayObject()) {
+ return capability.m_rejectFunction;
+ }
+
  ArrayObject* iterableArray = iterable->asArrayObject();
 
  // 6. Repeat

test/regression-tests/issue-25.js

@@ -0,0 +1,17 @@
+/* Copyright 2018-present Samsung Electronics Co., Ltd. and other contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+Object.prototype[1] = 0;
+Promise.race('multiline');

test/regression-tests/issue-30.js

@@ -0,0 +1,17 @@
+/* Copyright 2018-present Samsung Electronics Co., Ltd. and other contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+Object.prototype[1] = 0;
+Promise.all('x');