Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query string array support #182

Merged
merged 5 commits into from
Jun 23, 2022

Conversation

DanielRamosAcosta
Copy link
Owner

Fixes #172

@DanielRamosAcosta DanielRamosAcosta added the bug Something isn't working label Jun 17, 2022
@DanielRamosAcosta DanielRamosAcosta self-assigned this Jun 17, 2022
@DanielRamosAcosta
Copy link
Owner Author

@DanielRamosAcosta make a test for objects like {state: undefined}

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #182 (71eeee9) into main (f30380a) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   96.08%   96.33%   +0.24%     
==========================================
  Files          10       11       +1     
  Lines         179      191      +12     
  Branches       39       40       +1     
==========================================
+ Hits          172      184      +12     
  Misses          6        6              
  Partials        1        1              
Impacted Files Coverage Δ
src/TepperRunner.ts 98.38% <100.00%> (+0.05%) ⬆️
src/queries/objectToQueryString.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f30380a...71eeee9. Read the comment docs.

@DanielRamosAcosta DanielRamosAcosta merged commit b3b475a into main Jun 23, 2022
@DanielRamosAcosta DanielRamosAcosta deleted the fix/query-string-array-support branch June 23, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Querystring built-in API is legacy
2 participants