-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compress responses to clients sending accept-encoding: gzip
header
#1910
Comments
accept-encoding: gzip
headeraccept-encoding: gzip
header
@NoopDog to investigate potential gains. @noah-aviel-dove to investigate if we can enable gzip compression on API gateway. |
It's very easy to enable compression on API gateway. All we need to do is specify a nonnegative value for
|
I tried to time the requests to find the inflection point where compression becomes inefficient for small responses, but the round-trip elapsed time was too inconsistent regardless of payload size or compression to find any discernible pattern. |
Hannes to investigate ^^^ |
The most recent prod build log reveals that TF recreated the API Gateway during that build. This was expected since the upgrading instructions on another issue required deleting the API Gateway resource prior to https://gitlab.azul.data.humancellatlas.org/ucsc/azul/-/jobs/1630#L5189 We checked the API Gateway settings in the AWS console and found the compression setting to be disabled. We ran https://gitlab.azul.data.humancellatlas.org/ucsc/azul/-/jobs/1988#L3049 The AWS console now reflects that but
whereas on dev it works (look for
|
I'll wait until tomorrow, maybe there's a delay in propagating of the change to the CF edge servers. |
@hannes-ucsc to file a ticket with AWS support. |
Case # 8354981671 |
Response from AWS support:
That fixed it: Timings vary but improved by the expected 10-20%, barely noticeable, subjectively speaking. However, we shouldn't need to manually redeploy the stage. TF should do that for us. I was gonna chalk this up to #1951 but that fix was deployed at the same time, so it should have been active. My 2nd best guess is that the cause is in the vicinity of |
No description provided.
The text was updated successfully, but these errors were encountered: