Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DR-2597] Bump jib to 3.2.0 for skaffold 1.38.0 compatibility #1283

Merged
merged 1 commit into from
May 17, 2022

Conversation

okotsopoulos
Copy link
Contributor

@okotsopoulos okotsopoulos commented May 17, 2022

https://broadworkbench.atlassian.net/browse/DR-2597

When I onboarded, skaffold 1.38.0 was installed via our team brewfile. The team members I've talked to all have skaffold <= 1.35.1. This later version requires a later version of jib:

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/okotsopo/jade-data-repo/build.gradle' line: 29

* What went wrong:
An exception occurred applying plugin request [id: 'com.google.cloud.tools.jib', version: '2.7.1']
> Failed to apply plugin 'com.google.cloud.tools.jib'.
   > Jib plugin version is 2.7.1 but is required to be 3.2.0

Which itself required a workaround for nonexistent extraDirectories (jib PR where this enforcement was added):

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':jib'.
> extraDirectories.paths contain "from" directory that doesn't exist locally: /Users/okotsopo/jade-data-repo/build/gen-expanded

I was then able to skaffold run and see my new ok-jade-datarepo-api pod running.

Debugging in Slack: https://broadinstitute.slack.com/archives/C01VBGH431S/p1652730508162889

Request

Could someone with skaffold 1.35.1 (@nmalfroy ?) please check this branch out and see if skaffold run works for you?

@snf2ye
Copy link
Contributor

snf2ye commented May 17, 2022

Which itself required a workaround for nonexistent extraDirectories (GoogleContainerTools/jib#3542 where this enforcement was added)

Oh nice - great find and thanks for linking in the PR! Thanks for fixing this and allowing the upgrade.

@samanehsan
Copy link
Contributor

I checked out this branch and was able to do a scaffold run on skaffold v1.3.1!

@okotsopoulos okotsopoulos merged commit 9387aeb into develop May 17, 2022
@okotsopoulos okotsopoulos deleted the okotsopo/DR-2597-jib-3.2.0 branch May 17, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants