Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] [7.43.x] Upgrade JMXFetch to 0.47.6 #16366

Closed
wants to merge 6 commits into from

Conversation

scottopell
Copy link
Contributor

What does this PR do?

Backport of #16364

Motivation

See above PR

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

  • Run a java app with JMX metrics exposed (eg, Tomcat, activemq, solr)
  • Configure agent to collect jmx metrics
  • Ensure the JMX metrics are visible in the app

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left you one small piece of feedback from Docs. PR is approved.

releasenotes/notes/jmxfetch-0.47.6-5bd54d911d7a28c5.yaml Outdated Show resolved Hide resolved
@scottopell scottopell changed the title [backport] Upgrade JMXFetch to 0.47.6 [backport] [7.43.x] Upgrade JMXFetch to 0.47.6 Mar 30, 2023
@scottopell scottopell added this to the Release Maintenance milestone Mar 30, 2023
@scottopell scottopell marked this pull request as draft March 31, 2023 20:45
@scottopell
Copy link
Contributor Author

Back to draft until DataDog/jmxfetch#420 and DataDog/jmxfetch#419 land and we release a new jmxfetch version that we can reference here.

@scottopell scottopell closed this Apr 24, 2023
@dd-devflow dd-devflow bot deleted the fix/743-upgrade-jmxfetch branch April 19, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants