Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tagger] Extract list of tags to its own package #26884

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

davidor
Copy link
Member

@davidor davidor commented Jun 19, 2024

What does this PR do?

This PR is a refactor. No changes in functionality.

This PR extracts the list of tags handled by the tagger to its own package. This has a few advantages:

  • To know if a tag is added by the tagger or not now we just need to look at the list in the new file added in this PR.
  • Other projects will be able to use the constants defined instead of having to redeclare them. This was asked by the otel team.
  • Remove some duplication because some tags were defined in multiple places.

This PR is easier to review commit by commit.

Describe how to test/QA your changes

Skip. This should be covered by e2e and unit tests.

@davidor davidor added changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/container-platform The Container Platform Team qa/skip-qa labels Jun 19, 2024
@davidor davidor added this to the 7.56.0 milestone Jun 19, 2024
@davidor davidor requested review from a team as code owners June 19, 2024 10:39
@pr-commenter
Copy link

pr-commenter bot commented Jun 19, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=37098659 --os-family=ubuntu

Note: This applies to commit be81afb

@davidor
Copy link
Member Author

davidor commented Jun 19, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 19, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 30m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 2f2b52d into main Jun 19, 2024
267 checks passed
@dd-mergequeue dd-mergequeue bot deleted the davidor/contp-214-tags-list branch June 19, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/container-platform The Container Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants