Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installer): Pull & build datadog-packages from Gitlab (#27970) #28116

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

chouquette
Copy link
Contributor

What does this PR do?

Backport of #27970

Motivation

Fix OCI packaging/deploy jobs

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@chouquette chouquette added changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-delivery labels Aug 1, 2024
@chouquette chouquette requested a review from a team as a code owner August 1, 2024 07:08
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.94%. Comparing base (5c416e7) to head (43204e4).

Additional details and impacted files
@@           Coverage Diff           @@
##           7.55.x   #28116   +/-   ##
=======================================
  Coverage   44.93%   44.94%           
=======================================
  Files        2354     2354           
  Lines      272910   272910           
=======================================
+ Hits       122645   122647    +2     
+ Misses     140588   140584    -4     
- Partials     9677     9679    +2     
Flag Coverage Δ
amzn_aarch64 45.77% <ø> (-0.02%) ⬇️
centos_x86_64 45.68% <ø> (-0.01%) ⬇️
ubuntu_aarch64 45.77% <ø> (-0.01%) ⬇️
ubuntu_x86_64 45.78% <ø> (+<0.01%) ⬆️
windows_amd64 50.76% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Aug 1, 2024

Regression Detector

Regression Detector Results

Run ID: 2eb09ddb-af79-4114-bf3b-e49eb134ccdd

Baseline: 5c416e7
Comparison: 43204e4

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
tcp_syslog_to_blackhole ingress throughput +7.60 [-14.87, +30.08]
pycheck_1000_100byte_tags % cpu utilization +0.16 [-4.70, +5.02]
otel_to_otel_logs ingress throughput +0.06 [-0.30, +0.41]
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.03, +0.05]
trace_agent_msgpack ingress throughput +0.01 [+0.00, +0.02]
trace_agent_json ingress throughput +0.00 [-0.01, +0.01]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20]
file_tree memory utilization -0.53 [-0.63, -0.43]
idle memory utilization -0.53 [-0.57, -0.50]
basic_py_check % cpu utilization -1.68 [-4.37, +1.00]
uds_dogstatsd_to_api_cpu % cpu utilization -1.83 [-4.69, +1.03]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@chouquette
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 1, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in 7.55.x is 38m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 14f0b12 into 7.55.x Aug 1, 2024
233 checks passed
@dd-mergequeue dd-mergequeue bot deleted the chouquette/backport_oci_755 branch August 1, 2024 09:02
@github-actions github-actions bot added this to the 7.55.0 milestone Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants