[ASCII-2410] remove usage of global tagger

[GustavoCaso]

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=47128568 --os-family=ubuntu

Note: This applies to commit ada382a

[cit-pr-commenter]

Regression Detector

[cit-pr-commenter]

Go Package Import Differences

Baseline: b77289c
Comparison: ada382a

binary	os	arch	change
agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
agent	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
agent	windows	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
agent	darwin	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
agent	darwin	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
iot-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
iot-agent	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
heroku-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
cluster-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
cluster-agent	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
cluster-agent-cloudfoundry	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
cluster-agent-cloudfoundry	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
dogstatsd	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
dogstatsd	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
security-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
security-agent	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
trace-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
trace-agent	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
trace-agent	windows	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
trace-agent	darwin	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
trace-agent	darwin	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl
heroku-trace-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/core/tagger/noopimpl

[github-actions]

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between 32f5a2e and 8403aed.

tl;dr

Use these benchmarks as an insight tool during development.

1. Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.

2. The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

I need more help

First off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development.

If you would like a hand interpreting the results come chat with us in #serverless-agent in the internal DataDog slack or in #serverless in the public DataDog slack. We're happy to help!

Benchmark stats

goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │ baseline/benchmark.log │       current/benchmark.log        │
                                      │         sec/op         │   sec/op     vs base               │
api-gateway-appsec.json                            84.09µ ± 4%   83.35µ ± 7%       ~ (p=0.579 n=10)
api-gateway-kong-appsec.json                       66.07µ ± 8%   65.87µ ± 2%       ~ (p=0.631 n=10)
api-gateway-kong.json                              64.62µ ± 2%   64.30µ ± 1%       ~ (p=0.529 n=10)
api-gateway-non-proxy-async.json                   102.7µ ± 2%   104.6µ ± 1%  +1.82% (p=0.005 n=10)
api-gateway-non-proxy.json                         103.3µ ± 1%   104.4µ ± 1%  +1.09% (p=0.009 n=10)
api-gateway-websocket-connect.json                 69.10µ ± 1%   70.31µ ± 2%  +1.76% (p=0.004 n=10)
api-gateway-websocket-default.json                 62.05µ ± 1%   63.16µ ± 2%  +1.80% (p=0.002 n=10)
api-gateway-websocket-disconnect.json              62.33µ ± 1%   62.84µ ± 1%  +0.83% (p=0.011 n=10)
api-gateway.json                                   113.8µ ± 1%   115.0µ ± 1%  +1.03% (p=0.001 n=10)
application-load-balancer.json                     63.40µ ± 1%   63.73µ ± 2%       ~ (p=0.123 n=10)
cloudfront.json                                    46.63µ ± 3%   47.54µ ± 1%  +1.95% (p=0.023 n=10)
cloudwatch-events.json                             37.86µ ± 1%   38.18µ ± 1%       ~ (p=0.165 n=10)
cloudwatch-logs.json                               65.43µ ± 2%   65.69µ ± 2%       ~ (p=0.247 n=10)
custom.json                                        31.03µ ± 1%   31.07µ ± 1%       ~ (p=0.529 n=10)
dynamodb.json                                      92.23µ ± 1%   96.01µ ± 1%  +4.10% (p=0.000 n=10)
empty.json                                         29.35µ ± 1%   29.59µ ± 2%       ~ (p=0.353 n=10)
eventbridge-custom.json                            47.98µ ± 1%   47.96µ ± 1%       ~ (p=0.592 n=10)
eventbridge-no-bus.json                            46.56µ ± 2%   46.79µ ± 2%       ~ (p=0.247 n=10)
eventbridge-no-timestamp.json                      46.49µ ± 1%   46.95µ ± 1%  +1.01% (p=0.007 n=10)
eventbridgesns.json                                63.75µ ± 1%   64.13µ ± 1%       ~ (p=0.123 n=10)
eventbridgesqs.json                                71.14µ ± 1%   71.95µ ± 1%  +1.15% (p=0.043 n=10)
http-api.json                                      71.99µ ± 1%   72.81µ ± 2%  +1.14% (p=0.017 n=10)
kinesis-batch.json                                 70.23µ ± 2%   70.90µ ± 1%  +0.95% (p=0.015 n=10)
kinesis.json                                       54.92µ ± 2%   55.51µ ± 2%       ~ (p=0.089 n=10)
s3.json                                            60.17µ ± 2%   60.28µ ± 1%       ~ (p=0.631 n=10)
sns-batch.json                                     91.64µ ± 1%   93.57µ ± 1%  +2.10% (p=0.004 n=10)
sns.json                                           69.52µ ± 2%   69.82µ ± 2%       ~ (p=0.393 n=10)
snssqs.json                                        118.0µ ± 2%   119.7µ ± 1%       ~ (p=0.075 n=10)
snssqs_no_dd_context.json                          107.3µ ± 2%   107.0µ ± 2%       ~ (p=0.971 n=10)
sqs-aws-header.json                                60.15µ ± 1%   60.86µ ± 2%       ~ (p=0.143 n=10)
sqs-batch.json                                     96.16µ ± 1%   99.15µ ± 1%  +3.11% (p=0.000 n=10)
sqs.json                                           74.70µ ± 5%   73.09µ ± 2%       ~ (p=0.052 n=10)
sqs_no_dd_context.json                             69.55µ ± 4%   68.90µ ± 2%       ~ (p=0.315 n=10)
stepfunction.json                                  45.93µ ± 2%   47.31µ ± 3%       ~ (p=0.052 n=10)
geomean                                            65.69µ        66.26µ       +0.87%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │          B/op          │     B/op      vs base               │
api-gateway-appsec.json                           37.34Ki ± 0%   37.26Ki ± 0%  -0.19% (p=0.000 n=10)
api-gateway-kong-appsec.json                      26.93Ki ± 0%   26.94Ki ± 0%       ~ (p=0.592 n=10)
api-gateway-kong.json                             24.43Ki ± 0%   24.43Ki ± 0%       ~ (p=0.753 n=10)
api-gateway-non-proxy-async.json                  48.13Ki ± 0%   48.06Ki ± 0%  -0.14% (p=0.000 n=10)
api-gateway-non-proxy.json                        47.35Ki ± 0%   47.29Ki ± 0%  -0.13% (p=0.000 n=10)
api-gateway-websocket-connect.json                25.53Ki ± 0%   25.50Ki ± 0%  -0.11% (p=0.000 n=10)
api-gateway-websocket-default.json                21.43Ki ± 0%   21.41Ki ± 0%  -0.12% (p=0.000 n=10)
api-gateway-websocket-disconnect.json             21.22Ki ± 0%   21.19Ki ± 0%  -0.15% (p=0.000 n=10)
api-gateway.json                                  49.59Ki ± 0%   49.59Ki ± 0%       ~ (p=0.593 n=10)
application-load-balancer.json                    23.31Ki ± 0%   22.37Ki ± 0%  -4.02% (p=0.000 n=10)
cloudfront.json                                   17.68Ki ± 0%   17.66Ki ± 0%  -0.11% (p=0.012 n=10)
cloudwatch-events.json                            11.73Ki ± 0%   11.69Ki ± 0%  -0.33% (p=0.001 n=10)
cloudwatch-logs.json                              53.38Ki ± 0%   53.38Ki ± 0%       ~ (p=0.435 n=10)
custom.json                                       9.749Ki ± 0%   9.734Ki ± 0%  -0.15% (p=0.001 n=10)
dynamodb.json                                     40.81Ki ± 0%   40.78Ki ± 0%       ~ (p=0.055 n=10)
empty.json                                        9.311Ki ± 0%   9.291Ki ± 0%  -0.21% (p=0.004 n=10)
eventbridge-custom.json                           15.02Ki ± 0%   15.02Ki ± 0%       ~ (p=0.971 n=10)
eventbridge-no-bus.json                           14.00Ki ± 0%   13.99Ki ± 0%       ~ (p=0.868 n=10)
eventbridge-no-timestamp.json                     14.03Ki ± 0%   14.01Ki ± 0%  -0.19% (p=0.027 n=10)
eventbridgesns.json                               21.00Ki ± 0%   20.92Ki ± 0%  -0.36% (p=0.006 n=10)
eventbridgesqs.json                               25.19Ki ± 0%   25.13Ki ± 0%  -0.24% (p=0.035 n=10)
http-api.json                                     23.92Ki ± 0%   23.84Ki ± 0%  -0.32% (p=0.004 n=10)
kinesis-batch.json                                27.14Ki ± 0%   27.09Ki ± 0%       ~ (p=0.063 n=10)
kinesis.json                                      17.95Ki ± 0%   17.88Ki ± 0%  -0.38% (p=0.000 n=10)
s3.json                                           20.47Ki ± 0%   20.46Ki ± 0%       ~ (p=0.493 n=10)
sns-batch.json                                    39.93Ki ± 0%   39.98Ki ± 0%       ~ (p=0.143 n=10)
sns.json                                          25.16Ki ± 0%   25.19Ki ± 0%       ~ (p=0.436 n=10)
snssqs.json                                       53.88Ki ± 0%   53.86Ki ± 0%       ~ (p=0.870 n=10)
snssqs_no_dd_context.json                         47.57Ki ± 0%   47.59Ki ± 0%       ~ (p=0.840 n=10)
sqs-aws-header.json                               19.42Ki ± 0%   19.53Ki ± 1%       ~ (p=0.063 n=10)
sqs-batch.json                                    42.26Ki ± 1%   42.37Ki ± 0%  +0.27% (p=0.050 n=10)
sqs.json                                          26.26Ki ± 1%   26.21Ki ± 0%       ~ (p=0.363 n=10)
sqs_no_dd_context.json                            21.94Ki ± 1%   21.93Ki ± 1%       ~ (p=0.644 n=10)
stepfunction.json                                 14.27Ki ± 1%   14.21Ki ± 1%       ~ (p=0.424 n=10)
geomean                                           24.61Ki        24.56Ki       -0.21%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │       allocs/op        │ allocs/op   vs base                 │
api-gateway-appsec.json                             630.0 ± 0%   629.0 ± 0%       ~ (p=0.656 n=10)
api-gateway-kong-appsec.json                        488.0 ± 0%   488.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-kong.json                               466.0 ± 0%   466.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy-async.json                    725.0 ± 0%   725.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-non-proxy.json                          716.0 ± 0%   716.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-connect.json                  453.0 ± 0%   453.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-default.json                  379.0 ± 0%   379.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-disconnect.json               370.0 ± 0%   370.0 ± 0%       ~ (p=1.000 n=10)
api-gateway.json                                    791.0 ± 0%   791.0 ± 0%       ~ (p=1.000 n=10)
application-load-balancer.json                      353.0 ± 0%   352.0 ± 0%  -0.28% (p=0.000 n=10)
cloudfront.json                                     284.0 ± 0%   284.0 ± 0%       ~ (p=0.474 n=10)
cloudwatch-events.json                              220.0 ± 0%   220.0 ± 0%       ~ (p=0.474 n=10)
cloudwatch-logs.json                                215.5 ± 0%   215.0 ± 0%       ~ (p=1.000 n=10)
custom.json                                         168.0 ± 0%   168.0 ± 0%       ~ (p=1.000 n=10) ¹
dynamodb.json                                       589.0 ± 0%   589.0 ± 0%       ~ (p=0.628 n=10)
empty.json                                          160.0 ± 1%   159.5 ± 0%       ~ (p=0.350 n=10)
eventbridge-custom.json                             266.0 ± 0%   266.0 ± 0%       ~ (p=0.628 n=10)
eventbridge-no-bus.json                             257.5 ± 0%   257.0 ± 0%       ~ (p=1.000 n=10)
eventbridge-no-timestamp.json                       258.0 ± 0%   257.5 ± 0%       ~ (p=0.141 n=10)
eventbridgesns.json                                 326.0 ± 0%   325.5 ± 0%       ~ (p=0.082 n=10)
eventbridgesqs.json                                 367.0 ± 0%   367.0 ± 0%       ~ (p=0.750 n=10)
http-api.json                                       434.0 ± 0%   434.0 ± 0%       ~ (p=0.675 n=10)
kinesis-batch.json                                  392.0 ± 0%   391.5 ± 0%       ~ (p=0.176 n=10)
kinesis.json                                        287.0 ± 0%   286.0 ± 0%  -0.35% (p=0.002 n=10)
s3.json                                             359.0 ± 0%   359.0 ± 0%       ~ (p=0.895 n=10)
sns-batch.json                                      478.5 ± 0%   479.0 ± 0%       ~ (p=0.153 n=10)
sns.json                                            346.5 ± 0%   347.0 ± 0%       ~ (p=0.475 n=10)
snssqs.json                                         478.0 ± 0%   479.0 ± 0%       ~ (p=0.199 n=10)
snssqs_no_dd_context.json                           436.0 ± 1%   437.5 ± 0%       ~ (p=0.071 n=10)
sqs-aws-header.json                                 286.0 ± 0%   288.0 ± 1%  +0.70% (p=0.037 n=10)
sqs-batch.json                                      516.0 ± 2%   517.5 ± 0%       ~ (p=0.051 n=10)
sqs.json                                            365.0 ± 1%   364.0 ± 0%       ~ (p=0.290 n=10)
sqs_no_dd_context.json                              350.0 ± 1%   350.5 ± 1%       ~ (p=0.867 n=10)
stepfunction.json                                   237.5 ± 0%   237.0 ± 1%       ~ (p=0.801 n=10)
geomean                                             367.2        367.2       -0.02%
¹ all samples are equal