-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(buildimage): Deprecate the old buildimages update task #30365
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (I focused on the code ASC owns)
[Fast Unit Tests Report] On pipeline 47114491 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Should we move ownership of these files to agent ci infra team? |
@@ -0,0 +1,16 @@ | |||
import re |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 suggestion
I suggest moving libs/ciproviders
's ownership to agent ci infra team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, will do this on the refactoring PR #30370
Regression DetectorRegression Detector ResultsRun ID: c8258311-e4bb-42a2-850d-e122e4510a8e Metrics dashboard Target profiles Baseline: 3270886 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | basic_py_check | % cpu utilization | +2.48 | [-0.25, +5.21] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | +1.36 | [+1.26, +1.47] | 1 | Logs bounds checks dashboard |
➖ | otel_to_otel_logs | ingress throughput | +0.81 | [+0.01, +1.62] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | +0.39 | [-2.07, +2.85] | 1 | Logs |
➖ | file_tree | memory utilization | +0.19 | [+0.07, +0.32] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.17 | [-0.31, +0.66] | 1 | Logs |
➖ | idle | memory utilization | +0.05 | [+0.00, +0.10] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_idle | memory utilization | +0.03 | [-0.01, +0.08] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.03 | [-0.31, +0.36] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.10, +0.10] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.01 | [-0.24, +0.21] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.03 | [-0.27, +0.22] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.10 | [-0.16, -0.04] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.10 | [-0.28, +0.08] | 1 | Logs |
➖ | idle_all_features | memory utilization | -0.31 | [-0.41, -0.20] | 1 | Logs bounds checks dashboard |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.73 | [-1.45, -0.01] | 1 | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 |
✅ | idle | memory_usage | 10/10 |
✅ | idle_all_features | memory_usage | 10/10 |
✅ | quality_gate_idle | memory_usage | 10/10 |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
What does this PR do?
Deprecate the
pipeline.update-buildimages
task to use thebuildimages.update
oneMotivation
Remove a duplicated task and refactoring (moved gitlab related tasks to the gitlab modules)
Describe how to test/QA your changes
Invoke unit tests.
Possible Drawbacks / Trade-offs
Additional Notes
The last reference of old task is on the buildimage repo readme. I will fix this with a follow-up PR