Skip to content

Commit

Permalink
[RUMM-3399] Add message stating symbol processing will take 5 minutes
Browse files Browse the repository at this point in the history
  • Loading branch information
plousada committed Jul 14, 2023
1 parent 65dcf65 commit d25d1db
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 18 deletions.
39 changes: 21 additions & 18 deletions src/commands/dsyms/__tests__/upload.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -302,18 +302,19 @@ describe('execute', () => {
expect(code).toBe(0)
expect(output[1]).toContain('Starting upload with concurrency 20. ')
expect(output[2]).toContain('Will look for dSYMs in src/commands/dsyms/__tests__/fixtures/')
expect(output[3]).toContain('Will use temporary intermediate directory: ')
expect(output[4]).toContain('Will use temporary upload directory: ')
expect(output[5]).toContain(
expect(output[3]).toContain('Once dSYMs upload is successful files will be processed and ready to use within the next 5 minutes.')
expect(output[4]).toContain('Will use temporary intermediate directory: ')
expect(output[5]).toContain('Will use temporary upload directory: ')
expect(output[6]).toContain(
'Uploading C8469F85-B060-3085-B69D-E46C645560EA.zip (DDTest, arch: armv7, UUID: C8469F85-B060-3085-B69D-E46C645560EA)'
)
expect(output[6]).toContain(
expect(output[7]).toContain(
'Uploading 06EE3D68-D605-3E92-B92D-2F48C02A505E.zip (DDTest, arch: arm64, UUID: 06EE3D68-D605-3E92-B92D-2F48C02A505E)'
)
expect(output[7]).toContain(
expect(output[8]).toContain(
'Uploading 3BC12422-63CC-30E8-B916-E5006CE3286C.zip (DDTest, arch: arm64, UUID: 3BC12422-63CC-30E8-B916-E5006CE3286C)'
)
expect(output[10]).toContain('Handled 3 dSYMs with success')
expect(output[11]).toContain('Handled 3 dSYMs with success')
})

test('Should succeed with zip file input', async () => {
Expand All @@ -325,18 +326,19 @@ describe('execute', () => {
expect(code).toBe(0)
expect(output[1]).toContain('Starting upload with concurrency 20. ')
expect(output[2]).toContain('Will look for dSYMs in src/commands/dsyms/__tests__/fixtures/all.zip')
expect(output[3]).toContain('Will use temporary intermediate directory: ')
expect(output[4]).toContain('Will use temporary upload directory: ')
expect(output[5]).toContain(
expect(output[3]).toContain('Once dSYMs upload is successful files will be processed and ready to use within the next 5 minutes.')
expect(output[4]).toContain('Will use temporary intermediate directory: ')
expect(output[5]).toContain('Will use temporary upload directory: ')
expect(output[6]).toContain(
'Uploading C8469F85-B060-3085-B69D-E46C645560EA.zip (DDTest, arch: armv7, UUID: C8469F85-B060-3085-B69D-E46C645560EA)'
)
expect(output[6]).toContain(
expect(output[7]).toContain(
'Uploading 06EE3D68-D605-3E92-B92D-2F48C02A505E.zip (DDTest, arch: arm64, UUID: 06EE3D68-D605-3E92-B92D-2F48C02A505E)'
)
expect(output[7]).toContain(
expect(output[8]).toContain(
'Uploading 3BC12422-63CC-30E8-B916-E5006CE3286C.zip (DDTest, arch: arm64, UUID: 3BC12422-63CC-30E8-B916-E5006CE3286C)'
)
expect(output[10]).toContain('Handled 3 dSYMs with success')
expect(output[11]).toContain('Handled 3 dSYMs with success')
})

test('Should succeed with API key and site from datadog.json file', async () => {
Expand All @@ -350,18 +352,19 @@ describe('execute', () => {
expect(code).toBe(0)
expect(output[1]).toContain('Starting upload with concurrency 20. ')
expect(output[2]).toContain('Will look for dSYMs in src/commands/dsyms/__tests__/fixtures/')
expect(output[3]).toContain('Will use temporary intermediate directory: ')
expect(output[4]).toContain('Will use temporary upload directory: ')
expect(output[5]).toContain(
expect(output[3]).toContain('Once dSYMs upload is successful files will be processed and ready to use within the next 5 minutes.')
expect(output[4]).toContain('Will use temporary intermediate directory: ')
expect(output[5]).toContain('Will use temporary upload directory: ')
expect(output[6]).toContain(
'Uploading C8469F85-B060-3085-B69D-E46C645560EA.zip (DDTest, arch: armv7, UUID: C8469F85-B060-3085-B69D-E46C645560EA)'
)
expect(output[6]).toContain(
expect(output[7]).toContain(
'Uploading 06EE3D68-D605-3E92-B92D-2F48C02A505E.zip (DDTest, arch: arm64, UUID: 06EE3D68-D605-3E92-B92D-2F48C02A505E)'
)
expect(output[7]).toContain(
expect(output[8]).toContain(
'Uploading 3BC12422-63CC-30E8-B916-E5006CE3286C.zip (DDTest, arch: arm64, UUID: 3BC12422-63CC-30E8-B916-E5006CE3286C)'
)
expect(output[10]).toContain('Handled 3 dSYMs with success')
expect(output[11]).toContain('Handled 3 dSYMs with success')
})

test('Should use API Key from env over config from JSON file', async () => {
Expand Down
4 changes: 4 additions & 0 deletions src/commands/dsyms/renderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ export const renderCommandInfo = (basePath: string, poolLimit: number, dryRun: b
const basePathStr = chalk.green(`Will look for dSYMs in ${basePath}\n`)
fullStr += basePathStr

fullStr += chalk.green(
`Once dSYMs upload is successful files will be processed and ready to use within the next 5 minutes.\n`
)

return fullStr
}

Expand Down

0 comments on commit d25d1db

Please sign in to comment.