Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataDog flutter-symbols symbols output gives wrong information #1063

Open
KarlChow92 opened this issue Sep 20, 2023 · 1 comment
Open

DataDog flutter-symbols symbols output gives wrong information #1063

KarlChow92 opened this issue Sep 20, 2023 · 1 comment
Labels
bug Something isn't working rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps]

Comments

@KarlChow92
Copy link

KarlChow92 commented Sep 20, 2023 •
edited
Loading

Bug description

I have been using the following command: datadog-ci flutter-symbols upload to upload my symbols and I have discovered that it's actually giving the wrong output and not uploading my symbols.

My errors in DataDog are obfuscated and stayed obfuscated even when I run the command:
datadog-ci flutter-symbols upload --service-name xxxxxxx --dart-symbols-location . --ios-dsyms-location . --version 1.4.1

This command was run in the following folder:

Screenshot 2023-09-20 at 10 53 23 AM

The output was similar to this:

Starting upload.
Uploaing ios dSYMs at location .
Uploaing Flutter Dart Symbol Files at location .
  version: 1.4.1 service: xxxxxxxxxxxx flavor: release
⚠️ An error occured while invoking git: Error: fatal: not a git repository (or any of the parent directories): .git

Make sure the command is running within your git repository to fully leverage Datadog's git integration.
To ignore this warning use the --disable-git flag.
Starting upload with concurrency 20.
Will look for dSYMs in .
Will use temporary intermediate directory: /var/folders/sk/lg6yg69n1ln7n645kpl18cx00000gn/T/7126510579844003/datadog-ci/dsyms/intermediate
Will use temporary upload directory: /var/folders/sk/lg6yg69n1ln7n645kpl18cx00000gn/T/7126510579844003/datadog-ci/dsyms/upload
Uploading 492212CD-A9A0-353F-9C5F-EF5EA15510B2.zip (amf_sfmc_port_repo_flutter, arch: arm64, UUID: 492212CD-A9A0-353F-9C5F-EF5EA15510B2)
Uploading 131A0A41-46ED-38DB-95BB-77B2D895A655.zip (connectivity_plus, arch: arm64, UUID: 131A0A41-46ED-38DB-95BB-77B2D895A655)
Uploading 649BC5D0-271C-38B6-B964-F220C47ADE64.zip (country_codes, arch: arm64, UUID: 649BC5D0-271C-38B6-B964-F220C47ADE64)
Uploading AE938269-3419-397B-8FA9-FCFA8E60560C.zip (Datadog, arch: arm64, UUID: AE938269-3419-397B-8FA9-FCFA8E60560C)
Uploading 98AF7D71-0906-308F-8A01-1C74D58C7C8D.zip (device_info_plus, arch: arm64, UUID: 98AF7D71-0906-308F-8A01-1C74D58C7C8D)
Uploading ADFF39FD-5C5E-3C23-B975-40F23B53D26E.zip (DictionaryCoder, arch: arm64, UUID: ADFF39FD-5C5E-3C23-B975-40F23B53D26E)
Uploading 70A6DBE3-0DEC-3CF5-865F-33B91FCB3D35.zip (DTTJailbreakDetection, arch: arm64, UUID: 70A6DBE3-0DEC-3CF5-865F-33B91FCB3D35)
Uploading BC13DA08-F0CA-31AC-977B-55B66E648BA8.zip (FBLPromises, arch: arm64, UUID: BC13DA08-F0CA-31AC-977B-55B66E648BA8)
Uploading 96997B63-E392-370A-810C-E41B8DD96CC7.zip (FirebaseCore, arch: arm64, UUID: 96997B63-E392-370A-810C-E41B8DD96CC7)
Uploading 27070C2D-0079-37A1-883D-B50CDAE2716B.zip (FirebaseCoreDiagnostics, arch: arm64, UUID: 27070C2D-0079-37A1-883D-B50CDAE2716B)
Uploading 24538F9C-7893-38FD-9224-8B6138D697F2.zip (FirebaseCrashlytics, arch: arm64, UUID: 24538F9C-7893-38FD-9224-8B6138D697F2)
Uploading A567C62E-1612-3D99-9DB6-DD76DB1CB005.zip (FirebaseInstallations, arch: arm64, UUID: A567C62E-1612-3D99-9DB6-DD76DB1CB005)
Uploading 1C57DEA9-FF0A-39B6-957C-F0E60EF22C05.zip (flutter_app_badger, arch: arm64, UUID: 1C57DEA9-FF0A-39B6-957C-F0E60EF22C05)
Uploading D7158A53-AE58-3AB2-ABA4-6FBA43A30E14.zip (flutter_inappwebview, arch: arm64, UUID: D7158A53-AE58-3AB2-ABA4-6FBA43A30E14)
Uploading 03C2E07D-78E7-390D-A641-0E092CA030DE.zip (flutter_jailbreak_detection, arch: arm64, UUID: 03C2E07D-78E7-390D-A641-0E092CA030DE)
Uploading AD80929A-99A8-3246-9B4D-9E753C5046FD.zip (FMDB, arch: arm64, UUID: AD80929A-99A8-3246-9B4D-9E753C5046FD)
Uploading 533178B8-4635-3363-85B0-DD898F91C7CF.zip (gigya_flutter_plugin, arch: arm64, UUID: 533178B8-4635-3363-85B0-DD898F91C7CF)
Uploading 742088EE-BC1B-3581-BC3C-5473226F009C.zip (Gigya, arch: arm64, UUID: 742088EE-BC1B-3581-BC3C-5473226F009C)
Uploading DD589953-E484-3E40-9A09-1C83C063AFA3.zip (GoogleDataTransport, arch: arm64, UUID: DD589953-E484-3E40-9A09-1C83C063AFA3)
Uploading 1C85464B-76E6-33EB-90BB-2BF55BE7C525.zip (GoogleUtilities, arch: arm64, UUID: 1C85464B-76E6-33EB-90BB-2BF55BE7C525)
Uploading BB3196A5-8189-3C3D-B0C0-AC5D3E0E1A17.zip (nanopb, arch: arm64, UUID: BB3196A5-8189-3C3D-B0C0-AC5D3E0E1A17)
Uploading BA7CAF0B-678A-3C51-83AF-28E57BA1CD82.zip (notification_permissions, arch: arm64, UUID: BA7CAF0B-678A-3C51-83AF-28E57BA1CD82)
Uploading 14E264B3-8DEE-32CB-8F9C-704201A6C783.zip (OrderedSet, arch: arm64, UUID: 14E264B3-8DEE-32CB-8F9C-704201A6C783)
Uploading 0F084758-A766-34C7-BC73-E3646051FEE5.zip (package_info, arch: arm64, UUID: 0F084758-A766-34C7-BC73-E3646051FEE5)
Uploading BD6C01E5-FF9F-3B2A-8F91-D6D28415BF2E.zip (path_provider_ios, arch: arm64, UUID: BD6C01E5-FF9F-3B2A-8F91-D6D28415BF2E)
Uploading 10029B16-3E0D-34BD-BBF0-F84A084F7A9A.zip (Reachability, arch: arm64, UUID: 10029B16-3E0D-34BD-BBF0-F84A084F7A9A)
Uploading 6822D174-488C-3603-AB44-1F3FBE17CA24.zip (Runner, arch: arm64, UUID: 6822D174-488C-3603-AB44-1F3FBE17CA24)
Uploading D6330D3B-53A4-3AA1-BF5C-169C2E53742F.zip (share_plus, arch: arm64, UUID: D6330D3B-53A4-3AA1-BF5C-169C2E53742F)
Uploading EB362B72-E5D3-3CAA-ADDA-AB52DEC1F820.zip (shared_preferences_ios, arch: arm64, UUID: EB362B72-E5D3-3CAA-ADDA-AB52DEC1F820)
Uploading F44C9C6C-0D75-3203-B5A5-095B05E3C9F9.zip (sms_autofill, arch: arm64, UUID: F44C9C6C-0D75-3203-B5A5-095B05E3C9F9)
Uploading F0C28ACB-FCDE-3B4A-8479-777D251CD5C9.zip (sqflite, arch: arm64, UUID: F0C28ACB-FCDE-3B4A-8479-777D251CD5C9)
Uploading B02C7080-5B51-398D-AB27-4833A9353AFE.zip (uni_links, arch: arm64, UUID: B02C7080-5B51-398D-AB27-4833A9353AFE)
Uploading 8ADA062D-E1F4-3EC6-A6CA-82DC2BC83A39.zip (url_launcher_ios, arch: arm64, UUID: 8ADA062D-E1F4-3EC6-A6CA-82DC2BC83A39)
Uploading F208C20A-1F6C-3322-964C-5DE15A1C5020.zip (video_player_avfoundation, arch: arm64, UUID: F208C20A-1F6C-3322-964C-5DE15A1C5020)
Uploading 4BAE1662-6CD1-3C0B-AD4A-7F12F3301558.zip (wakelock, arch: arm64, UUID: 4BAE1662-6CD1-3C0B-AD4A-7F12F3301558)
Uploading 4FB24789-FDD0-3F1D-A4B7-47BB2777E112.zip (webview_flutter_wkwebview, arch: arm64, UUID: 4FB24789-FDD0-3F1D-A4B7-47BB2777E112)

Command summary:
✅ Uploaded 36 dSYMs in 5.117 seconds.

Command summary:
✅ Uploaded symbol 1 file in 5.496 seconds.

While it shows that I have uploaded one symbols file it actually doesn't since It doesn't symbolise my errors in DataDog.

Describe what you expected

I expected the errors to be symbolised and the symbols file to be uploaded. I am not sure what the one file is that it's actually uploading.

Steps to reproduce the issue

  1. Create similar folder structure as of the image in bug description.
  2. Run command similar to: datadog-ci flutter-symbols upload --service-name xxxxxxx --dart-symbols-location . --ios-dsyms-location . --version 1.4.1
  3. Observe results.

Additional context

Mac OS: 13.3.1 (a)
datadog-ci: v1.15.0

If I would run: datadog-ci flutter-symbols upload --service-name xxxxxxxxx --dart-symbols-location ./1.4.1-2931/symbols --ios-dsyms-location . --version 1.4.1, note the more specific path of my symbols location, I actually can confirm that my symbols are being uploaded since the errors are symbolised.

See output here:

Starting upload.
Uploaing ios dSYMs at location .
Uploaing Flutter Dart Symbol Files at location ./1.4.1-2931/symbols
  version: 1.4.1 service: xxxxxxxxx  flavor: release
⚠️ An error occured while invoking git: Error: fatal: not a git repository (or any of the parent directories): .git

Make sure the command is running within your git repository to fully leverage Datadog's git integration.
To ignore this warning use the --disable-git flag.
Starting upload with concurrency 20.
Will look for dSYMs in .
Will use temporary intermediate directory: /var/folders/sk/lg6yg69n1ln7n645kpl18cx00000gn/T/5551674766936653/datadog-ci/dsyms/intermediate
Will use temporary upload directory: /var/folders/sk/lg6yg69n1ln7n645kpl18cx00000gn/T/5551674766936653/datadog-ci/dsyms/upload
Uploading 492212CD-A9A0-353F-9C5F-EF5EA15510B2.zip (amf_sfmc_port_repo_flutter, arch: arm64, UUID: 492212CD-A9A0-353F-9C5F-EF5EA15510B2)
Uploading 131A0A41-46ED-38DB-95BB-77B2D895A655.zip (connectivity_plus, arch: arm64, UUID: 131A0A41-46ED-38DB-95BB-77B2D895A655)
Uploading 649BC5D0-271C-38B6-B964-F220C47ADE64.zip (country_codes, arch: arm64, UUID: 649BC5D0-271C-38B6-B964-F220C47ADE64)
Uploading AE938269-3419-397B-8FA9-FCFA8E60560C.zip (Datadog, arch: arm64, UUID: AE938269-3419-397B-8FA9-FCFA8E60560C)
Uploading 98AF7D71-0906-308F-8A01-1C74D58C7C8D.zip (device_info_plus, arch: arm64, UUID: 98AF7D71-0906-308F-8A01-1C74D58C7C8D)
Uploading ADFF39FD-5C5E-3C23-B975-40F23B53D26E.zip (DictionaryCoder, arch: arm64, UUID: ADFF39FD-5C5E-3C23-B975-40F23B53D26E)
Uploading 70A6DBE3-0DEC-3CF5-865F-33B91FCB3D35.zip (DTTJailbreakDetection, arch: arm64, UUID: 70A6DBE3-0DEC-3CF5-865F-33B91FCB3D35)
Uploading BC13DA08-F0CA-31AC-977B-55B66E648BA8.zip (FBLPromises, arch: arm64, UUID: BC13DA08-F0CA-31AC-977B-55B66E648BA8)
Uploading 96997B63-E392-370A-810C-E41B8DD96CC7.zip (FirebaseCore, arch: arm64, UUID: 96997B63-E392-370A-810C-E41B8DD96CC7)
Uploading 27070C2D-0079-37A1-883D-B50CDAE2716B.zip (FirebaseCoreDiagnostics, arch: arm64, UUID: 27070C2D-0079-37A1-883D-B50CDAE2716B)
Uploading 24538F9C-7893-38FD-9224-8B6138D697F2.zip (FirebaseCrashlytics, arch: arm64, UUID: 24538F9C-7893-38FD-9224-8B6138D697F2)
Uploading A567C62E-1612-3D99-9DB6-DD76DB1CB005.zip (FirebaseInstallations, arch: arm64, UUID: A567C62E-1612-3D99-9DB6-DD76DB1CB005)
Uploading 1C57DEA9-FF0A-39B6-957C-F0E60EF22C05.zip (flutter_app_badger, arch: arm64, UUID: 1C57DEA9-FF0A-39B6-957C-F0E60EF22C05)
Uploading D7158A53-AE58-3AB2-ABA4-6FBA43A30E14.zip (flutter_inappwebview, arch: arm64, UUID: D7158A53-AE58-3AB2-ABA4-6FBA43A30E14)
Uploading 03C2E07D-78E7-390D-A641-0E092CA030DE.zip (flutter_jailbreak_detection, arch: arm64, UUID: 03C2E07D-78E7-390D-A641-0E092CA030DE)
Uploading AD80929A-99A8-3246-9B4D-9E753C5046FD.zip (FMDB, arch: arm64, UUID: AD80929A-99A8-3246-9B4D-9E753C5046FD)
Uploading 533178B8-4635-3363-85B0-DD898F91C7CF.zip (gigya_flutter_plugin, arch: arm64, UUID: 533178B8-4635-3363-85B0-DD898F91C7CF)
Uploading 742088EE-BC1B-3581-BC3C-5473226F009C.zip (Gigya, arch: arm64, UUID: 742088EE-BC1B-3581-BC3C-5473226F009C)
Uploading DD589953-E484-3E40-9A09-1C83C063AFA3.zip (GoogleDataTransport, arch: arm64, UUID: DD589953-E484-3E40-9A09-1C83C063AFA3)
Uploading 1C85464B-76E6-33EB-90BB-2BF55BE7C525.zip (GoogleUtilities, arch: arm64, UUID: 1C85464B-76E6-33EB-90BB-2BF55BE7C525)
Uploading BB3196A5-8189-3C3D-B0C0-AC5D3E0E1A17.zip (nanopb, arch: arm64, UUID: BB3196A5-8189-3C3D-B0C0-AC5D3E0E1A17)
Uploading BA7CAF0B-678A-3C51-83AF-28E57BA1CD82.zip (notification_permissions, arch: arm64, UUID: BA7CAF0B-678A-3C51-83AF-28E57BA1CD82)
Uploading 14E264B3-8DEE-32CB-8F9C-704201A6C783.zip (OrderedSet, arch: arm64, UUID: 14E264B3-8DEE-32CB-8F9C-704201A6C783)
Uploading 0F084758-A766-34C7-BC73-E3646051FEE5.zip (package_info, arch: arm64, UUID: 0F084758-A766-34C7-BC73-E3646051FEE5)
Uploading BD6C01E5-FF9F-3B2A-8F91-D6D28415BF2E.zip (path_provider_ios, arch: arm64, UUID: BD6C01E5-FF9F-3B2A-8F91-D6D28415BF2E)
Uploading 10029B16-3E0D-34BD-BBF0-F84A084F7A9A.zip (Reachability, arch: arm64, UUID: 10029B16-3E0D-34BD-BBF0-F84A084F7A9A)
Uploading 6822D174-488C-3603-AB44-1F3FBE17CA24.zip (Runner, arch: arm64, UUID: 6822D174-488C-3603-AB44-1F3FBE17CA24)
Uploading D6330D3B-53A4-3AA1-BF5C-169C2E53742F.zip (share_plus, arch: arm64, UUID: D6330D3B-53A4-3AA1-BF5C-169C2E53742F)
Uploading EB362B72-E5D3-3CAA-ADDA-AB52DEC1F820.zip (shared_preferences_ios, arch: arm64, UUID: EB362B72-E5D3-3CAA-ADDA-AB52DEC1F820)
Uploading F44C9C6C-0D75-3203-B5A5-095B05E3C9F9.zip (sms_autofill, arch: arm64, UUID: F44C9C6C-0D75-3203-B5A5-095B05E3C9F9)
Uploading F0C28ACB-FCDE-3B4A-8479-777D251CD5C9.zip (sqflite, arch: arm64, UUID: F0C28ACB-FCDE-3B4A-8479-777D251CD5C9)
Uploading B02C7080-5B51-398D-AB27-4833A9353AFE.zip (uni_links, arch: arm64, UUID: B02C7080-5B51-398D-AB27-4833A9353AFE)
Uploading 8ADA062D-E1F4-3EC6-A6CA-82DC2BC83A39.zip (url_launcher_ios, arch: arm64, UUID: 8ADA062D-E1F4-3EC6-A6CA-82DC2BC83A39)
Uploading F208C20A-1F6C-3322-964C-5DE15A1C5020.zip (video_player_avfoundation, arch: arm64, UUID: F208C20A-1F6C-3322-964C-5DE15A1C5020)
Uploading 4BAE1662-6CD1-3C0B-AD4A-7F12F3301558.zip (wakelock, arch: arm64, UUID: 4BAE1662-6CD1-3C0B-AD4A-7F12F3301558)
Uploading 4FB24789-FDD0-3F1D-A4B7-47BB2777E112.zip (webview_flutter_wkwebview, arch: arm64, UUID: 4FB24789-FDD0-3F1D-A4B7-47BB2777E112)

Command summary:
✅ Uploaded 36 dSYMs in 5.162 seconds.
Uploading Flutter Symbol File ./1.4.1-2931/symbols/app.ios-arm64.symbols

Command summary:
✅ Uploaded symbol 2 files in 8.458 seconds.

Again, it uploads 2 files while I expect only 1. Not sure where the other 1 comes from and what it is.

Command

flutter-symbols
@KarlChow92 KarlChow92 added the bug Something isn't working label Sep 20, 2023
@github-actions github-actions bot added the rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps] label Sep 20, 2023
@fuzzybinary
Copy link
Contributor

Hi @KarlChow92,

I'll take a look at this. I think what's happening is the command summary is actually telling you it uploaded 1 (iOS) or 2 (iOS and Dart) platforms worth of symbols, not individual files, but the output here is incredibly confusing. You get two summaries because the Flutter symbol upload actually calls the iOS one internally.

I'll work on getting clearer output for this command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fuzzybinary @KarlChow92