Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can't tell what --disable-git does for sourcemaps upload #1087

Open
dbalatero opened this issue Oct 13, 2023 · 1 comment
Open

I can't tell what --disable-git does for sourcemaps upload #1087

dbalatero opened this issue Oct 13, 2023 · 1 comment
Labels
rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps] topic:environment-variables

Comments

@dbalatero
Copy link

dbalatero commented Oct 13, 2023

Our deploy pipeline operates on a shallow clone of our Git repository, and does not have a .git folder. This is causing the following error message to be written when we attempt to upload sourcemaps:

$ datadog-ci sourcemaps upload ...

1033 | @monologue/graphite-app:prod-build: version: 985f396a538677c1b02808a80c9202b78d479128 service: graphite-app project path:
1034 | @monologue/graphite-app:prod-build: ⚠️ An error occured while invoking git: Error: fatal: not a git repository (or any parent up to mount point /codebuild)
1035 | @monologue/graphite-app:prod-build: Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
1036 | @monologue/graphite-app:prod-build:
1037 | @monologue/graphite-app:prod-build: Make sure the command is running within your git repository to fully leverage Datadog's git integration.
1038 | @monologue/graphite-app:prod-build: To ignore this warning use the --disable-git flag.

I'm open to passing the --disable-git flag, but I cannot tell what features I'm going to break by enabling the flag. The documentation does not make this clear.

Can you clarify what --disable-git breaks if I enable it? I'd like to see:

  • the README updated with that context
  • the --help output of the CLI command updated with the context

if it's easy enough to add!

@dbalatero
Copy link
Author

Related issue: #753

@Drarig29 Drarig29 added the rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps] label Oct 16, 2023
@Drarig29 Drarig29 changed the title I can't tell what --disable-git does for sourcemaps upload I can't tell what --disable-git does for sourcemaps upload Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps] topic:environment-variables
Projects
None yet
Development

No branches or pull requests

2 participants