Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter-symbols not uploading android mapping.txt with --android-mapping-location #1117

Closed
bounth opened this issue Nov 16, 2023 · 2 comments
Labels
bug Something isn't working rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps]

Comments

@bounth
Copy link

bounth commented Nov 16, 2023

Bug description

The command --android-mapping-location ./build/app/outputs/mapping/devRelease/mapping.txt doesn't upload the mapping file as intended from the datadog-ci log output

Uploading Android Mapping File ./build/app/outputs/mapping/devRelease/mapping.txt
Mapping upload finished: 0

The command ls shows that the mapping.txt location is correct.

ls ./build/app/outputs/mapping/devRelease
configuration.txt
mapping.txt
resources.txt
seeds.txt
usage.txt

Describe what you expected

Expect to see something similar to successful upload of dSYM and symbols file

✅ Uploaded 58 dSYMs in 58.895 seconds.
✅ Uploaded symbol 6 files in 61.192 seconds.

Steps to reproduce the issue

Full log

==> Start
==> Switching to working directory: /Users/vagrant/git
+ curl -L --fail https:/DataDog/datadog-ci/releases/latest/download/datadog-ci_darwin-x64 --output /usr/local/bin/datadog-ci
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

 37 73.6M   37 27.6M    0     0  65.4M      0  0:00:01 --:--:--  0:00:01 65.4M
100 73.6M  100 73.6M    0     0   106M      0 --:--:-- --:--:-- --:--:--  169M
+ chmod +x /usr/local/bin/datadog-ci
+ datadog-ci version
v2.23.1
+ '[' -d ./build/app/outputs/symbols ']'
+ datadog-ci flutter-symbols upload --service-name myi-mobile --flavor dev --version 3.10.0-19 --dart-symbols-location ./build/app/outputs/symbols --android-mapping-location ./build/app/outputs/mapping/devRelease/mapping.txt --ios-dsyms
Starting upload. 
Uploading ios dSYMs at location ./build/ios/archive/Runner.xcarchive/dSYMs
Uploading Android Proguard Mapping File at location ./build/app/outputs/mapping/devRelease/mapping.txt
Uploading Flutter Dart Symbol Files at location ./build/app/outputs/symbols
  version: 3.10.0-19 service: myi-mobile flavor: dev
Please ensure you use the same values during SDK initialization to guarantee the success of the symbolication process.
After upload is successful symbol files will be processed and ready to use within the next 5 minutes.
Starting upload with concurrency 20. 
Will look for dSYMs in build/ios/archive/Runner.xcarchive/dSYMs
Once dSYMs upload is successful files will be processed and ready to use within the next 5 minutes.
Will use temporary intermediate directory: /var/folders/yy/6kcn9mkd5svdbqnznwf474f00000gn/T/2439658940657953.5/datadog-ci/dsyms/intermediate
Will use temporary upload directory: /var/folders/yy/6kcn9mkd5svdbqnznwf474f00000gn/T/2439658940657953.5/datadog-ci/dsyms/upload
Uploading C12D510B-6D2C-34D8-AF75-4E50191C50A3.zip (datadog_webview_tracking, arch: arm64, UUID: C12D510B-6D2C-34D8-AF75-4E50191C50A3)
Uploading 178F83C6-AC50-36ED-B0A3-85410067C8FA.zip (Datadog, arch: arm64, UUID: 178F83C6-AC50-36ED-B0A3-85410067C8FA)
[... Remove 56 lines of Uploading dSYMs for readability ...]
Command summary:
✅ Uploaded 58 dSYMs in 58.895 seconds.
Uploading Android Mapping File ./build/app/outputs/mapping/devRelease/mapping.txt
Mapping upload finished: 0
Uploading Flutter Symbol File ./build/app/outputs/symbols/app.android-arm.symbols
Uploading Flutter Symbol File ./build/app/outputs/symbols/app.android-arm64.symbols
Uploading Flutter Symbol File ./build/app/outputs/symbols/app.android-x64.symbols
Uploading Flutter Symbol File ./build/app/outputs/symbols/app.ios-arm64.symbols
Command summary:
✅ Uploaded symbol 6 files in 61.192 seconds.
+ ls ./build/app/outputs/mapping/devRelease
configuration.txt
mapping.txt
resources.txt
seeds.txt
usage.txt

Additional context

datadog-ci version v2.23.1

Command

flutter-symbols

@bounth bounth added the bug Something isn't working label Nov 16, 2023
@github-actions github-actions bot added the rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps] label Nov 16, 2023
@Drarig29
Copy link
Contributor

Drarig29 commented Nov 16, 2023

Hi @bounth, I think there is a misunderstanding 😅

The 0 here means "Success":

return UploadStatus.Success

So you should be good to go!

Were you only confused about the output, or did you notice some problem apart from this?

Otherwise I'll close the issue and we'll create a card to improve the message.

@bounth
Copy link
Author

bounth commented Nov 17, 2023

Thanks for the clarification, I was confused by the output, as I expected to see ✅ Uploaded 1 file in X seconds.

I am closing the ticket !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps]
Projects
None yet
Development

No branches or pull requests

2 participants