Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--minified-path-prefix not working with path #1157

Closed
nogwater opened this issue Jan 15, 2024 · 1 comment
Closed

--minified-path-prefix not working with path #1157

nogwater opened this issue Jan 15, 2024 · 1 comment
Labels
bug Something isn't working rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps]

Comments

@nogwater
Copy link

Bug description

I'm able to publish sourcemaps and have them get picked up for logs if I use the full URL prefix. For example:

datadog-ci sourcemaps upload ./dist --minified-path-prefix=https://qa.example.com/app/ ...

That works for QA, but we use the same build and versions for QA and Production, so I'd like to use the absolute path option like:

datadog-ci sourcemaps upload ./dist --minified-path-prefix=/app/ ...

But whenever I try that, the sourcemaps publish but don't show in the logs view.

Describe what you expected

I expect to be able to upload sourcemaps that work with multiple domain names.

Steps to reproduce the issue

  1. Build project with sourcemaps
  2. Publish using datadog-ci sourcemaps upload ./dist --minified-path-prefix=/app/ ... where the deployed /app/ directory has the same content as the build output /dist/ directory.
  3. Generate logs
  4. View logs in Datadog

Additional context

  • node version v20.10.0
  • "@datadog/datadog-ci": "2.27.0"
  • "@datadog/browser-logs": "5.7.0"

Command

sourcemaps

@nogwater nogwater added the bug Something isn't working label Jan 15, 2024
@github-actions github-actions bot added the source-code-integration Related to [git-metadata] label Jan 15, 2024
@nogwater
Copy link
Author

My mistake. I had a mismatch in the service name. Still, it's surprising that the sourcemap linking works with the full domain but a mismatched service name. I'll close this issue.

@Drarig29 Drarig29 added rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps] and removed source-code-integration Related to [git-metadata] labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps]
Projects
None yet
Development

No branches or pull requests

2 participants