-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flutter-symbols upload
doesn't support glob patterns for android-mapping-location
#1413
Comments
Hi @feinstein The reason this is not supported is because it could result in resolving to multiple mapping files, which would not be valid. We could perform the glob lookup and warn you if you resolve to multiple mapping files, but that would be a feature request, not a bug. Additionally, if you are uploading mapping files for different flavors under the same version, you must specify the flavor both to Let me know if that makes sense and if you want to request that we still support globs in this way. |
Hi @fuzzybinary, yes I think it makes sense. I think I declared the flavor in the app, but how do I do it in the CI? |
For |
Bug description
If I try to run
I get this error:
But if I specify the full path for the
mapping.txt
it works fine.I think the bug is in here: https:/DataDog/datadog-ci/blob/master/src/commands/flutter-symbols/upload.ts#L512, and this code already imports
glob
, so it should be an easy fix.Describe what you expected
I expected to be able to provide globs in the android mapping location, as it can change depending on the flavor or artifact type (apk or appbundle) we are building.
Steps to reproduce the issue
No response
Additional context
No response
Command
flutter-symbols
The text was updated successfully, but these errors were encountered: