Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error shown when timestamp doesn't match (junit test upload) #996

Closed
slevenstein opened this issue Jul 18, 2023 · 3 comments
Closed

No error shown when timestamp doesn't match (junit test upload) #996

slevenstein opened this issue Jul 18, 2023 · 3 comments
Labels
bug Something isn't working ci-visibility Related to [junit, gate, metric, tag, trace, dora, deployment]

Comments

@slevenstein
Copy link

Bug description

When uploading a junit test result file to Datadog with test cases containing timestamps with a difference from the current time greater than a few hours, no error is shown in the command line, but no results show in Datadog.

I recall reading that the timestamp shouldn't be too much later than the current time in one other Issue, but I wish that was made a bit more clear to have saved me some time.

This is all that is shown in the command line:

✅ Uploaded 1 files in 0.518 seconds.
=================================================================================================
* View detailed reports on Datadog (they can take a few minutes to become available)
=================================================================================================

Describe what you expected

Either an error is thrown in the shell output saying that there is an error with the the timestamp differential
or...
Results are shown in Datadog despite the timestamp differential (possibly if a certain argument/flag is given)*

*would be helpful for testing

Steps to reproduce the issue

  • produce any junit test result file
  • change minimum one test suite to have a timestamp that is ~4 hours earlier than the current time
  • run datadog-ci junit upload --service <service_name> <path> [<path> ...]
  • check to see successful results in shell and no tests appearing under Test Runs in Datadog

Additional context

datadog-ci version:
v2.17.2

Command

junit

@slevenstein slevenstein added the bug Something isn't working label Jul 18, 2023
@github-actions github-actions bot added the ci-visibility Related to [junit, gate, metric, tag, trace, dora, deployment] label Jul 18, 2023
@slevenstein
Copy link
Author

Related to this and saw you added a waning in the documentation, so up to you all if you want to close this

#923

@juan-fernandez
Copy link
Contributor

hey @slevenstein ! Thanks for the report. This is indeed annoying, but we want to keep the processing at the library as light as possible, to make it faster and not to duplicate logic, since the processing of the file is done at the backend. I'll have a look anyway, maybe there's an fast way to check timestamps

@juan-fernandez
Copy link
Contributor

so we already do some basic validation to the xml, so we do partially parse it. To check the timestamps, we would have to go through a potentially huge report though, which we want to avoid doing. I'll close this. Thanks for the report anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci-visibility Related to [junit, gate, metric, tag, trace, dora, deployment]
Projects
None yet
Development

No branches or pull requests

2 participants