[git-metadata] Make exported function upload to gitdb #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpelliard
commented
Feb 28, 2024
Comment on lines
+57
to
+58
| // no-op logger | ||
| const log = new Logger((s: string) => {}, LogLevel.INFO) |
There was a problem hiding this comment.
The output of the serverless plugin is minimalistic when everything goes well (see below), so I think we want to avoid spitting a lot of debug/info logs.
We may also reconsider this in the future and allow passing a custom logger as parameter, but it doesn't seem needed for now.
Note that in case of errors, an exception will be throwned and logged by the serverless plugin to the command output:
samarcan
approved these changes
Feb 28, 2024
This was referenced Feb 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
datadog-ci git-metadata uploadcommand both:But the
uploadGitCommitShafunction that is exported and used in the serverless plugin (here: https:/DataDog/serverless-plugin-datadog/blob/51b7844efd6224d1a4fb5c1215453aac3038f915/src/index.ts#L302) only upload to the sourcemap intake.We want all upload tooling to synchronize GitDB, and eventually deprecate the sourcemap store for Git metadata.
This PR updates the exported function to also synchronize GitDB.