Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[dep] Bump glob to 11.0.0 (#1381)" #1398

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

Drarig29
Copy link
Contributor

@Drarig29 Drarig29 commented Aug 1, 2024

What and why?

This PR reverts #1381.

The functionality works fine on all versions of Node.js that we support, but glob@11 officially dropped support for Node.js versions below 20.

How?

Revert the PR.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@Drarig29 Drarig29 requested review from a team as code owners August 1, 2024 08:57
@Drarig29 Drarig29 added the dependencies Pull requests that update a dependency file label Aug 1, 2024
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: corentin.girard/revert-glob-upgrade
Commit report: 1badfff
Test service: datadog-ci-tests

✅ 0 Failed, 8768 Passed, 0 Skipped, 3m 52.26s Total Time

@Drarig29 Drarig29 merged commit e86fb45 into master Aug 1, 2024
18 of 19 checks passed
@Drarig29 Drarig29 deleted the corentin.girard/revert-glob-upgrade branch August 1, 2024 09:00
@Drarig29 Drarig29 mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants