Show error message when payload is invalid #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 112 Passed, 0 Skipped, 1m 1.77s Total Time |
Drarig29
reviewed
Aug 23, 2024
Drarig29
reviewed
Aug 23, 2024
amaanq
approved these changes
Aug 24, 2024
Comment on lines
+24
to
+28
| let fullStr = '' | ||
| fullStr += chalk.red(`Cannot generate payload for file ${reportPath}.\n`) | ||
| fullStr += chalk.red(`Make sure you run the command inside a git repository and the SBOM file is valid\n`) | ||
|
|
||
| return chalk.red(`Cannot generate payload for file ${reportPath}.\n`) | ||
| return fullStr |
There was a problem hiding this comment.
I think you can just do something like
return chalk.red(
`Cannot generate payload for file ${reportPath}.\n` +
`Ensure that you run the command inside a git repository, and that the SBOM file is valid.\n`
)Unfortunately GH wont let me make suggestions when there's a deletion 😑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
How?
Ensure we have only one path passed as parameter
Show an error and exit if we cannot generate the payload