[ci-visibility] Add --tags-file and --measures-file options
#1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigo-roca
added
the
ci-visibility
Datadog ReportBranch report: ✅ 0 Failed, 2978 Passed, 0 Skipped, 1m 47.55s Total duration (1m 4.05s time saved) |
rodrigo-roca
requested review from
anmarchenko and
juan-fernandez
and removed request for
anmarchenko
hestonhoffman
approved these changes
Aug 26, 2024
juan-fernandez
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Adds the option
--tags-filefor thetagcommand and the--measures-filefor themeasurecommand. Also improves error handling in thetagcommand (by displaying the error details and not only the status code). Those options allow to send multiple tags in bulk using a JSON file. The reason we are adding this is that adding large amounts of tags is very tedious to do through the command line only.How?
The user can provide a file path to a
.jsonfile and we will read all the tags / measures inside of it.tagcommand, we will convert booleans and numbers to strings, emitting a warning if it is a number since it should be reported using themeasurecommand instead.measurecommand, everything that is not a number will be ignored.Review checklist