Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix some instructions on test overrides #1433

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[docs] Fix some instructions on test overrides #1433

merged 1 commit into from
Sep 3, 2024

Conversation

Drarig29
Copy link
Contributor

@Drarig29 Drarig29 commented Sep 3, 2024

What and why?

I tried to use --override 'locations=["pl:test-corentin-preprod-e23cc6f215a2bd991b512080f81eb556"]' but the backend didn't accept it:

[p8z-bd4-y8z] Failed to trigger tests: query on [...]/trigger/ci returned: "The value provided for parameter 'locations' is invalid"

How?

The right format is --override locations="pl:test-corentin-preprod-e23cc6f215a2bd991b512080f81eb556"

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@Drarig29 Drarig29 added documentation Improvements or additions to documentation synthetics Related to [synthetics] labels Sep 3, 2024
@Drarig29 Drarig29 marked this pull request as ready for review September 3, 2024 14:30
@Drarig29 Drarig29 requested review from a team as code owners September 3, 2024 14:30
AntoineDona
AntoineDona approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@AntoineDona AntoineDona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Drarig29 Drarig29 merged commit 602266f into master Sep 3, 2024
20 checks passed
@Drarig29 Drarig29 deleted the corentin.girard/syn-readme-nits branch September 3, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineDona AntoineDona AntoineDona approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation synthetics Related to [synthetics]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drarig29 @AntoineDona