Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNTH-15675] Report timed out retries #1440

Merged
merged 6 commits into from
Sep 12, 2024

Conversation

Drarig29
Copy link
Contributor

@Drarig29 Drarig29 commented Sep 6, 2024

What and why?

This PR fixes a bug where timed out retries were sometimes not reported.

Bug description:

  • If a result (e.g. result ID 1) is an intermediate failed result (expected to be retried), its result ID is saved as reported,
  • Now, if the retry times out, then the result ID is unchanged, resulting in datadog-ci thinking the result was already reported.

How?

In a backend PR, we added the max_retries property.

If the result is timed_out && retries < max_retries, then we report it as a residual result.

This PR also fixes the JUnit reporter by not saving intermediate results in the JUnit file, and adds a few properties (retries, max_retries, initial_result_id) to results in the JUnit file.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@Drarig29 Drarig29 added the synthetics Related to [synthetics] label Sep 6, 2024
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Sep 6, 2024

Datadog Report

Branch report: corentin.girard/SYNTH-15675/report-timed-out-retries
Commit report: f5cb9bf
Test service: datadog-ci-tests

✅ 0 Failed, 1636 Passed, 0 Skipped, 1m 56.34s Total duration (1m 31.2s time saved)

@Drarig29 Drarig29 force-pushed the corentin.girard/SYNTH-15675/report-timed-out-retries branch from 7005c58 to a60a483 Compare September 9, 2024 11:59
@Drarig29 Drarig29 marked this pull request as ready for review September 10, 2024 16:07
@Drarig29 Drarig29 requested review from a team as code owners September 10, 2024 16:07
src/commands/synthetics/batch.ts Show resolved Hide resolved
@Drarig29 Drarig29 merged commit 34843fd into master Sep 12, 2024
18 checks passed
@Drarig29 Drarig29 deleted the corentin.girard/SYNTH-15675/report-timed-out-retries branch September 12, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
synthetics Related to [synthetics]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants