Refactor sfn Lambda injection code my merging two functions #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lym953
commented
Sep 16, 2024
| if (Parameters) { | ||
| Parameters[`Payload.$`] = 'States.JsonMerge($$, $, false)' | ||
| } | ||
| export const addTraceContextToLambdaParameters = (Parameters: ParametersType): void => { |
There was a problem hiding this comment.
Change Parameters param to be non-null, so the null-check can be removed.
|
|
||
| // payload field not set | ||
| if (!step.Parameters.hasOwnProperty('Payload.$') && !step.Parameters.hasOwnProperty('Payload')) { | ||
| addTraceContextToLambdaParameters(step.Parameters) |
There was a problem hiding this comment.
Adding addTraceContextToLambdaParameters() before every return true
Datadog ReportBranch report: ✅ 0 Failed, 376 Passed, 0 Skipped, 1m 26.56s Total duration (2m 2.32s time saved) |
lym953
added
serverless
lym953
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Currently the
injectContextForLambdaFunctions()function roughly looks like this:It calls
shouldUpdateStepForTracesMerging().This PR merges the two functions by moving the code of
shouldUpdateStepForTracesMerging()intoinjectContextForLambdaFunctions().Why?
We will soon have different instrumentation strategies depending on the existing state of Lambda definition, so
shouldUpdateStepForTracesMerging()which has a boolean return value will no longer work.Design doc: Fixing Step Function Instrumentation
A short description of what changes this PR introduces and why.
Testing
Passed the touched automated tests
Review checklist