Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lambda][flare] Ask for user confirmation before sending files to support #952

Conversation

nhulston
Copy link
Contributor

@nhulston nhulston commented Jul 3, 2023

What and why?

For more context on what Lambda Flare is, please read the description in this PR: #924

We want to ask users for confirmation before sending their files to support.
If they answer no, the flare files are not sent and are deleted
They must answer yes before the files are sent to support.
This is intended to:

  1. Give the user an opportunity to check the files and see if there is anything they don't want to send to support
  2. Prevent users from accidentally spamming their support ticket with files

How?

Use inquirer to prompt the user for confirmation.
Exit the program early if they answer no, continue otherwise.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jul 3, 2023

Datadog Report

Branch report: nicholas.hulston/serverless-flare/ask-before-sending-flare-files
Commit report: cddb492

datadog-ci-tests: 3 Failed (0 Known Flaky), 0 New Flaky, 4488 Passed, 0 Skipped, 1m 46.58s Wall Time

❌ Failed Tests (3)

  • lambda flare does not send when user answers prompt with no - src/commands/lambda/__tests__/flare.test.ts - Details

    Expand for error
     �[2mexpect(�[22m�[36m�[107mreceived�[49m�[39m�[2m).�[22mtoMatchSnapshot�[2m()�[22m
     
     Snapshot name: \`lambda flare does not send when user answers prompt with no 1\`
     
     �[35m�[103m- Snapshot  - 1�[49m�[39m
     �[36m�[107m+ Received  + 1�[49m�[39m
     
     �[33m@@ -6,11 +6,11 @@�[39m
     �[2m  🔍 Fetching Lambda function configuration...�[22m
     
     ...
    
  • lambda flare does not send when user answers prompt with no - src/commands/lambda/__tests__/flare.test.ts - Details

    Expand for error
     �[2mexpect(�[22m�[36m�[107mreceived�[49m�[39m�[2m).�[22mtoMatchSnapshot�[2m()�[22m
     
     Snapshot name: \`lambda flare does not send when user answers prompt with no 1\`
     
     �[35m�[103m- Snapshot  - 1�[49m�[39m
     �[36m�[107m+ Received  + 1�[49m�[39m
     
     �[33m@@ -6,11 +6,11 @@�[39m
     �[2m  🔍 Fetching Lambda function configuration...�[22m
     
     ...
    
  • lambda flare does not send when user answers prompt with no - src/commands/lambda/__tests__/flare.test.ts - Details

    Expand for error
     �[2mexpect(�[22m�[36m�[107mreceived�[49m�[39m�[2m).�[22mtoMatchSnapshot�[2m()�[22m
     
     Snapshot name: \`lambda flare does not send when user answers prompt with no 1\`
     
     �[35m�[103m- Snapshot  - 1�[49m�[39m
     �[36m�[107m+ Received  + 1�[49m�[39m
     
     �[33m@@ -6,11 +6,11 @@�[39m
     �[2m  🔍 Fetching Lambda function configuration...�[22m
     
     ...
    

@nhulston nhulston force-pushed the nicholas.hulston/serverless-flare/ask-before-sending-flare-files branch from aba13e0 to be1f4fe Compare July 3, 2023 17:22
@nhulston nhulston force-pushed the nicholas.hulston/serverless-flare/ask-before-sending-flare-files branch from be1f4fe to cddb492 Compare July 3, 2023 17:23
@nhulston nhulston closed this Jul 3, 2023
@nhulston nhulston deleted the nicholas.hulston/serverless-flare/ask-before-sending-flare-files branch July 3, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant