[synthetics] Support tunneled multi-step tests #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ |
Drarig29
commented
Jul 8, 2023
| `The tunnel is only supported with HTTP API tests and Browser tests (public ID: ${test.public_id}, type: ${ | ||
| test.type | ||
| }${test.subtype ? `, sub-type: ${test.subtype}` : ''}).` | ||
| `The tunnel is only supported with HTTP API tests and Browser tests (${details.join(', ')}).` |
There was a problem hiding this comment.
I kept this error message because a multi-step test is a subtype of API test so in a sense, HTTP steps are HTTP API tests.
jakepruitt
approved these changes
Jul 11, 2023
| `The tunnel is only supported with HTTP API tests and Browser tests (public ID: ${test.public_id}, type: ${ | ||
| test.type | ||
| }${test.subtype ? `, sub-type: ${test.subtype}` : ''}).` | ||
| `The tunnel is only supported with HTTP API tests and Browser tests (${details.join(', ')}).` |
Drarig29
deleted the
corentin.girard/SYNTH-10330/support-multi-step-tests-in-tunnel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Closes #959
Currently, multi-step tests are forbidden to run in the tunnel but HTTP steps in multi-step tests are now supported.
How?
step.typeandstep.subtypeinto aisTestSupportedByTunnel()utility function.httpsteps.Review checklist