[junit] Use uuidV4 for filename #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ |
rodrigo-roca
changed the title
AdrianLC
reviewed
Jul 14, 2023
AdrianLC
approved these changes
Jul 14, 2023
juan-fernandez
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
LGTM, but we need to add the new dependencies to https:/DataDog/datadog-ci/blob/master/LICENSE-3rdparty.csv.
Also, let's wait for the approval from someone else from datadog-ci team, since this is adding a new dependency and it affects other commands
duncanista
approved these changes
Jul 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
If we send the normal filename it can contain some characters that would cause 400 errors at the intake. Now we create a uuidv4 for the filename and send the original filename somewhere else.
How?
Use uuid package and send filename somewhere else as
_dd.report_nameReview checklist