This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
writer: simplify monitor #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran command:
mv backoff writer/
AlexJF
reviewed
Oct 24, 2018
| @@ -65,7 +65,7 @@ func (w *multiSender) Send(p *Payload) { | |||
| } | |||
| } | |||
|
|
|||
| func (w *multiSender) Monitor() <-chan interface{} { return w.mch } | |||
| func (w *multiSender) monitor() <-chan monitorEvent { return w.mch } | |||
There was a problem hiding this comment.
Why make Monitor private? This way, no one outside of this package will be able to use a sender?
| type eventType int | ||
|
|
||
| const ( | ||
| eventTypeSuccess eventType = iota |
There was a problem hiding this comment.
Again, if these are private no one outside of this package will be able to use a sender. If this is indeed your intention we should set the whole PayloadSender and everything directly related to it as private and only leave actual writers public.
There was a problem hiding this comment.
That's the plan, yeah. Nobody's using them outside of writer, so there is no point to export them or make them visible in the public documentation. Most of these packages should be internal anyway.
Would you like me to do that within the scope of this PR?
AlexJF
approved these changes
Oct 24, 2018
|
Thank you Alex. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this change:
backoffpackage intowriterfolder.