Instrument JBoss Modules to relax visibility rules during transform requests #3896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
force-pushed
the
mcculls/jbossModules
branch
from
be216f9
to
602df16
Compare
…g transform requests
mcculls
force-pushed
the
mcculls/jbossModules
branch
from
602df16
to
31507b9
Compare
bantonsson
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Uses same general approach as #2321 to widen agent resource and class lookups to include dependent modules. Only checks the first level of dependencies because in practice that's been enough for OSGi and it makes the solution simpler.
Motivation
This relaxation of modularity rules is sometimes necessary when injecting advice, because it may refer to related packages that would have been imported if the original code had needed them.