Do not fail if git info is missing #4711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
approved these changes
Feb 10, 2023
smola
changed the title
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/ignore-missing-git-info
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR changes CI visibility subsystem initialisation so that it does not fail in case the tracer cannot detect customer's Git information.
Motivation
Some customers use non-standard set ups and run CI visibility in environments where Git info is not available.
While many CI visibility features rely on Git info being there, the core functionality does not require it.
So in case it is missing, we should still do as much as we can, and not fail.