Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source file path detection for Kotlin #4766

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Feb 19, 2023

What Does This Do

This change updates logic that detects class source file paths, so that Kotlin classes are supported.

Motivation

The logic is used by CI Visibility part of the tracer to set source code related tags.
Some of CI Visibility customers are using it with Kotlin-based projects.

Additional Notes

The change consisted of three main parts:

  • update the list of file extensions that are added to repository index, adding .kt
  • add logic to infer class source language
  • update condition for parsing class information to obtain the source file name attribute (previously that was done only for package-private classes, not it is also done for non-Java classes)

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the comp: ci visibility Continuous Integration Visibility label Feb 19, 2023
@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review February 19, 2023 18:42
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 7d0d558 into master Feb 22, 2023
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/source-file-detection-for-kotlin branch February 22, 2023 09:08
@github-actions github-actions bot added this to the 1.9.0 milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: ci visibility Continuous Integration Visibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants