Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align DD_TRACE_PROPAGATION_STYLE* names with other tracers #4786

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

bantonsson
Copy link
Contributor

What Does This Do

Changes some names of DD_TRACE_PROPAGATION_STYLE_* settings to align with other Datadog tracers.

Motivation

Minimize discrepancies in configuration between Datadog tracers.

Additional Notes

This is a breaking change if someone started using DD_TRACE_PROPAGATION_STYLE* settings and the B3 propagator since B3 now mean B3 multi header while before it meant B3 single header. The risk of this is considered low, since the setting has not been documented yet.

@bantonsson bantonsson added tag: breaking change Breaking changes comp: context propagation Trace context propagation labels Feb 23, 2023
@bantonsson bantonsson requested a review from a team as a code owner February 23, 2023 10:04
@bantonsson bantonsson self-assigned this Feb 23, 2023
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the NoneCodec. We should not find compatibility issue with it 😉

@bantonsson bantonsson merged commit 06e90dc into master Feb 23, 2023
@bantonsson bantonsson deleted the ban/align-propagation-names branch February 23, 2023 10:55
@github-actions github-actions bot added this to the 1.9.0 milestone Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: context propagation Trace context propagation tag: breaking change Breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants