Add 'env' tag assertion to test frameworks integration tests #4791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
tag: no release notes
richardstartin
approved these changes
Feb 23, 2023
richardstartin
deleted the
nikita-tkachenko/fix-ci-tests-env-tag-failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This change updates integration tests that verify test frameworks instrumentation (junit4, junit5, test NG).
The update is to add
envtag assertion for every emitted span.Motivation
A recent change introduced logic that populates
envtag with a default value if it is missing (only when running the tracer in agentless mode).The integration tests require every span tag to be asserted, which is why assert for
envtag needs to be added.Additional Notes
It is only verified that the tag is always present, its contents are checked by the tests that were added for the earlier change.